Use Constructor#getParameterCount() instead of getParameterTypes().length #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngth The issue with `Constructor#getParameterTypes` that each time it creates a new array by calling `clone` on existing one. It does not make sense for the cases when only knowledge about array size is required
cowtowncoder
approved these changes
Oct 18, 2022
Member
|
Interesting: all other uses have been replaced earlier, not sure how this was left (this method is in Java 8 so it could only be used in Jackson 2.12 or so when baseline increased to Java 8). Thanks! |
|
This breaks compatibility with Android < API26, see #3412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with
Constructor#getParameterTypesthat each time it creates a new array by callingcloneon existing one. It does not make sense for the cases when only knowledge about array size is required