Skip to content

Conversation

siy
Copy link
Contributor

@siy siy commented Oct 8, 2020

The purpose of this feature is to enable strict field ordering (without prioritization of properties referenced by @JsonCreator).
This feature is extremely useful in cases when serialized output need to be, for example, predictably and interoperably hashed.

@cowtowncoder
Copy link
Member

First of all, thank you for submitting this PR: it seems useful and necessary. I'll have to look a bit deeper to make sure I understand consequences. I may also have to consider one tactical challenge wrt MapperFeature additions (we are getting close to a limit).

One thing tho: I think you may want to rebase this against 2.12, as 3.0 is still not close to getting released, and "master" branch is for 3.0. I am planning to get 2.12.0-rc1 out soon so this could conceivably make it in.

@siy
Copy link
Contributor Author

siy commented Oct 12, 2020

Closing this PR in favor of #2879

@siy siy closed this Oct 12, 2020
@siy
Copy link
Contributor Author

siy commented Oct 12, 2020

OK, switching to 2.12 makes sense.

@siy
Copy link
Contributor Author

siy commented Oct 15, 2020

First of all, thank you for submitting this PR: it seems useful and necessary. I'll have to look a bit deeper to make sure I understand consequences. I may also have to consider one tactical challenge wrt MapperFeature additions (we are getting close to a limit).

One thing tho: I think you may want to rebase this against 2.12, as 3.0 is still not close to getting released, and "master" branch is for 3.0. I am planning to get 2.12.0-rc1 out soon so this could conceivably make it in.

I've submitted reworked version as #2879. Please, review it and let me know if anything need to be changed. This change is really important for our current project and I'd like to have it included into next release.

@cowtowncoder
Copy link
Member

Thanks -- I'll add notes on the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants