Merge forward JDK-6-compatible equals() and hashcode() implementations into JsonTypeInfo.Value of master
#230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks but 3.0 will be based on at least Java 8 and probably later 17. No point in holding back those implementations since code should not need to be changed a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is for forwards-compatiblity with 3.0. As discussed in #229 (comment), same as title. I would like to see the implemenations to be "exactly" the same.
Background
Originated from backporting
JsonTypeInfo.Valueof Jackson 3.0 into Jackson 2.16 in #229. Theequals()andhashcode()implementations ofJsonTypeInfo.Valuein Jackson 3.0 (master branch) could not be directly copied because of its usage of JDK7 util methodsObjects.equals()andObjects.hashcode()util methods, so ended up using the internal Objects.hashcode() implementation.