Disable faulthandler for pytest. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses
jpypeto run Java code from Python.There is an annoying issue where, when
pytestis combined withjpype, the latter sometimes crashes with a Segmentation Fault all the way at the end when automatically trying to shut down the Java Virtual Machine (after all tests have already been run and passed). This sometimes causes our github workflows to report failure, and the solution is always just to... re-run it again and hope it doesn't crash the second time.I found an Issue about this over on the github repo of jpype itself, and the solution proposed all the way at the end there is to pass
-p no:faulthandlertopytest. It looks like this is also the solution that was implemented in the CI of jpype itself. So, that's what I also try here.It was a non-deterministic issue so I can't be 100% sure, but I made the build re-run many times for this PRs and didn't see it again, so I hope it's fixed. I did once have it fail with
ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently runningthrough a Stable Baselines import though, not sure yet what to do about that.