Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete methods #79

Closed
wants to merge 1 commit into from
Closed

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Oct 24, 2024

No description provided.

@Mike-CZ Mike-CZ requested a review from thaarok October 24, 2024 10:11
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just noticed, following ABI is used from the Sonic client:

  {
    "constant": false,
    "inputs": [
      {
        "internalType": "uint256[]",
        "name": "offlineTimes",
        "type": "uint256[]"
      },
      {
        "internalType": "uint256[]",
        "name": "offlineBlocks",
        "type": "uint256[]"
      },
      {
        "internalType": "uint256[]",
        "name": "uptimes",
        "type": "uint256[]"
      },
      {
        "internalType": "uint256[]",
        "name": "originatedTxsFee",
        "type": "uint256[]"
      }
    ],
    "name": "sealEpoch",
    "outputs": [],
    "payable": false,
    "stateMutability": "nonpayable",
    "type": "function"
  },

Seems we need to use the variant without the "usedGas" param (or to change the Sonic code)...

@Mike-CZ
Copy link
Collaborator Author

Mike-CZ commented Oct 25, 2024

Sorry, I just noticed, following ABI is used from the Sonic client:

...

Let's keep it for further discussion then.

@thaarok thaarok deleted the branch sonic_sfc November 4, 2024 17:13
@thaarok thaarok closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants