Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OZ][N-11] Code Cohesion and Readability #120

Merged
merged 6 commits into from
Jan 31, 2025
Merged

[OZ][N-11] Code Cohesion and Readability #120

merged 6 commits into from
Jan 31, 2025

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Dec 13, 2024

This PR imrpoves readibility.

The epochEndTime getter was made public in https://github.com/Fantom-foundation/opera-sfc/pull/119/files

@Mike-CZ Mike-CZ requested a review from thaarok December 13, 2024 16:50
thaarok
thaarok reviewed Dec 16, 2024
View reviewed changes
contracts/sfc/SFC.sol Outdated Show resolved Hide resolved
thaarok
thaarok requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using names originatedTxsFee and accumulatedOriginatedTxsFee was correct in here.

@Mike-CZ
Merge branch 'main' into mike/oz-n-11
48b8ceb 
# Conflicts:
#	contracts/sfc/SFC.sol
#	contracts/test/UnitTestSFC.sol
@Mike-CZ
Remove unused events
401fcab
@Mike-CZ
Remove unused method
cba9a84
@Mike-CZ
Copy link
Collaborator Author

Mike-CZ commented Jan 31, 2025

Using names originatedTxsFee and accumulatedOriginatedTxsFee was correct in here.

Reverted to keep original naming.

@Mike-CZ Mike-CZ requested a review from thaarok January 31, 2025 13:28
thaarok
thaarok previously approved these changes Jan 31, 2025
View reviewed changes
@Mike-CZ
Merge branch 'main' into mike/oz-n-11
d6467ca 
# Conflicts:
#	contracts/sfc/ConstantsManager.sol
@Mike-CZ Mike-CZ requested a review from thaarok January 31, 2025 14:02
@Mike-CZ Mike-CZ merged commit 2520ec9 into main Jan 31, 2025
2 checks passed
@Mike-CZ Mike-CZ deleted the mike/oz-n-11 branch January 31, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaarok thaarok thaarok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-CZ @thaarok