[OZ][N-02] Functions Are Updating the State Without Event Emissions #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaarok
reviewed
Jan 31, 2025
| snapshot.endBlock, | ||
| snapshot.baseRewardPerSecond, | ||
| snapshot.totalSupply | ||
| ); |
There was a problem hiding this comment.
I am really not sure if we want to introduce an even emission into the epoch sealing...
| @@ -328,6 +355,8 @@ contract SFC is OwnableUpgradeable, UUPSUpgradeable, Version { | |||
| snapshot.totalStake = snapshot.totalStake + receivedStake; | |||
| } | |||
| snapshot.validatorIDs = nextValidatorIDs; | |||
|
|
|||
| emit SealedEpochValidators(currentEpoch(), snapshot.totalStake, snapshot.validatorIDs); | |||
There was a problem hiding this comment.
At least I would remove the snapshot.validatorIDs from the event, as that may become big as the network grows. Who is interested may find the info in the external-internal tx calldata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds event emissions into
ConstantsManagerandSFCcontracts.