Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constants manager #108

Merged
merged 14 commits into from
Jan 31, 2025
Merged

Update constants manager #108

merged 14 commits into from
Jan 31, 2025

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Dec 13, 2024

This PR updates constants manager by:

  • fixing burnt fee and treasury fee share never exceeding 100% in sum
  • removing targetGasPowerPerSecond and gasPriceBalancingCounterweight as they are not used anymore
  • adding test coverage

It also updates NetworkInitializer to match values used on mainnet launch.

@Mike-CZ Mike-CZ requested a review from thaarok December 13, 2024 08:01
thaarok
thaarok previously approved these changes Dec 16, 2024
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes seems reasonable to me.

@Mike-CZ Mike-CZ changed the base branch from mike/disable_initializers to main January 31, 2025 11:30
@Mike-CZ Mike-CZ dismissed thaarok’s stale review January 31, 2025 11:30

The base branch was changed.

# Conflicts:
#	contracts/sfc/SFC.sol
@Mike-CZ Mike-CZ requested a review from thaarok January 31, 2025 11:33
# Conflicts:
#	contracts/sfc/ConstantsManager.sol
#	contracts/sfc/NetworkInitializer.sol
@Mike-CZ Mike-CZ merged commit 47a34c4 into main Jan 31, 2025
2 checks passed
@Mike-CZ Mike-CZ deleted the mike/update_consts_manager branch January 31, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants