Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OZ][N-09] Non-Upgradable ConstantsManager Inherits Upgradeable Contracts #101

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Nov 26, 2024

This PR replaces OwnableUpgradeable package with Ownable package for constants manager.

@Mike-CZ Mike-CZ requested review from thaarok and jmpike November 26, 2024 09:02
@thaarok
Copy link
Collaborator

thaarok commented Nov 26, 2024

What is the reason for this change?
The only difference should be the position of the storage slot. (At the start of the address space for Ownable, while at specific address for OwnableUpgradable.) It is not even cheaper, it only introduce another dependency into the code.

Update: The only reason for this change is to avoid confusion of auditors with the "Upgradable" name of the dependency. This was not even requested by them, they just need to get our confirmation this contract is not going to be upgradable.

Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it will be better this way.

@Mike-CZ Mike-CZ changed the title Replace Ownable package for contants manager [OZ][N-09] Non-Upgradable ConstantsManager Inherits Upgradeable Contracts Dec 13, 2024
@Mike-CZ Mike-CZ merged commit adfcf6c into main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants