Add constructor for constants manager

Fantom-foundation · Nov 11, 2024 · 7e5e5f2 · 7e5e5f2
1 parent 6d96335
commit 7e5e5f2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/contracts/sfc/ConstantsManager.sol b/contracts/sfc/ConstantsManager.sol
@@ -47,7 +47,7 @@ contract ConstantsManager is OwnableUpgradeable {
      */
     error ValueTooLarge();
 
-    function initialize(address owner) external initializer {
+    constructor(address owner) initializer {
         __Ownable_init(owner);
     }
 

diff --git a/contracts/sfc/NetworkInitializer.sol b/contracts/sfc/NetworkInitializer.sol
@@ -24,8 +24,7 @@ contract NetworkInitializer {
         NodeDriver(_driver).initialize(_auth, _evmWriter, _owner);
         NodeDriverAuth(_auth).initialize(_sfc, _driver, _owner);
 
-        ConstantsManager consts = new ConstantsManager();
-        consts.initialize(address(this));
+        ConstantsManager consts = new ConstantsManager(address(this));
         consts.updateMinSelfStake(500000 * 1e18);
         consts.updateMaxDelegatedRatio(16 * Decimal.unit());
         consts.updateValidatorCommission((15 * Decimal.unit()) / 100);

diff --git a/contracts/test/UnitTestConstantsManager.sol b/contracts/test/UnitTestConstantsManager.sol
@@ -4,6 +4,8 @@ pragma solidity 0.8.27;
 import {ConstantsManager} from "../sfc/ConstantsManager.sol";
 
 contract UnitTestConstantsManager is ConstantsManager {
+    constructor(address owner) ConstantsManager(owner) {}
+
     function updateMinSelfStake(uint256 v) external override onlyOwner {
         minSelfStake = v;
     }

diff --git a/contracts/test/UnitTestSFC.sol b/contracts/test/UnitTestSFC.sol
@@ -61,8 +61,7 @@ contract UnitTestNetworkInitializer {
         NodeDriver(_driver).initialize(_auth, _evmWriter, _owner);
         NodeDriverAuth(_auth).initialize(_sfc, _driver, _owner);
 
-        UnitTestConstantsManager consts = new UnitTestConstantsManager();
-        consts.initialize(address(this));
+        UnitTestConstantsManager consts = new UnitTestConstantsManager(address(this));
         consts.updateMinSelfStake(0.3175000 * 1e18);
         consts.updateMaxDelegatedRatio(16 * Decimal.unit());
         consts.updateValidatorCommission((15 * Decimal.unit()) / 100);