fancyholograms: Add support for pre-1.19.4 clients#190
Open
Maks1116 wants to merge 1 commit intoFancyInnovations:mainfrom
Open
fancyholograms: Add support for pre-1.19.4 clients#190Maks1116 wants to merge 1 commit intoFancyInnovations:mainfrom
Maks1116 wants to merge 1 commit intoFancyInnovations:mainfrom
Conversation
|
This would be awesome to get |
|
Possible to make it also works when VV is only installed on the Proxy? Currently, it would not apply the workaround i guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
ViaBackwards cannot correctly translate multi-line text displays for clients older than 1.19.4 (see ViaVersion/ViaBackwards#1029). This adds a workarround that spawns multiple single-line text displays for legacy clients instead, which ViaBackwards can translate correctly.
✅ Checklist
Fixes #issue_numberorCloses #issue_numbermainbranch🔍 Changes
When ViaVersion is detected and a player connects with a pre-1.19.4 client, text holograms are rendered as separate single-line displays.
🧪 How to Test