Refactor ScrollIndicator to remove unnecessary parent view and stream… #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line layout handling The changes made in `ScrollIndicator.tsx` involve removing the parent view reference and simplifying the layout handling for both `FlatList` and `ScrollView`. This reduces complexity and improves performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a View wrapper causes a lot of trouble if you simply replace it with a ScrollView. This breaks the layout, but I found a more efficient solution. I tested it, and it works.
The changes made in
ScrollIndicator.tsxinvolve removing the parent view reference and simplifying the layout handling for bothFlatListandScrollView. This reduces complexity and improves performance.