CheckConditionalAction AND CountTargetsAction auto-succeed if no target found - leads to missions succeeding when condition is failed

[ubertpendragon]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

If you use CheckConditionalAction and a target is not found, it makes the check succeed.
If a target is missing the check should clearly fail and not display an error message !

The problem is that, for example, if you target a monster, and the monster despawns (eaten), the check will succeed, even if the check was specifically about checking if the monster is alive.
The same could happen with an item that "explodes" and removes itself.

raptorescort mission will succeed if Rex dies and is eaten (despawns)
you will not see the error message (because it's round end?)

            <CheckConditionalAction targettag="rex" logicaloperator="And">
              <Conditional IsDead="False" />
              <Conditional InPlayerSubmarine="true" />
              <Failure>
                <SetDataAction identifier="manandhisraptor_rexdied" operation="set" value="true" />
              </Failure>
            </CheckConditionalAction>
          </Success>
        </CountTargetsAction>

---

Side note:
Trying to make a simple "creature escort" mission is nightmarish
Gotomission doesnt have a way to trigger a failed state through even (most mission hide their states in the code)
I'm janking my way through original content and half of it is bugged

Reproduction steps

1. Start campaign
2. unlockmission raptorescort
3. Teleport Rex away from the sub
4. Spawn a dozen crawlers around Rex
5. Wait for crawlers to eat Rex
6. Teleportsub endoutpost
7. Mission failed successfully

Bug prevalence

Just once

Single player or multiplayer?

Single player

-

No response

Version

v1.8.8.1 (Calm Before the Storm Hotfix 2)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[ubertpendragon]

In the traitor event Naturevsnurture2, you are supposed to grow and hatch a mudraptor egg
It uses a chain of CheckConditionalAction to check if the egg is still alive

But when the egg is destroyed, it is removed, therefore automatically succeeding the checks.
First thing I did was shoot the egg, mission succeeded

[ubertpendragon]

This also applies to CountTargetsAction

The level needs to big enough, generate a Great Sea level, trigger this event and use killmonsters
If far enough the monsters will despawn immediately, automatically succeeding the check

    <!-- killmonsters will validate this if crawlers are far enough from the sub (they will get despawned)-->
    <ScriptedEvent identifier="capturelivecrawlereventBUGGED">
      <SpawnAction speciesname="crawler" TargetTag="capturetarget" amount="3" SpawnLocation="MainPath" offset="500" />
      <TagAction criteria="player" tag="player" />
      <TagAction criteria="hull" tag="playerhull" submarinetype="Player" />
      <Label name="checkcrawlerinside" />
      <WaitAction time="1" />
      <!-- check if a crawler is inside the sub, I also tried  <Conditional InPlayerSubmarine="true" />  -->
      <CountTargetsAction targettag="capturetarget" hulltag="playerhull" CompareToTarget="capturetarget" MinPercentageRelativeToTarget="30" >
        <Conditional IsDead="false" />
        <Success>
          <ConversationAction targettag="player" text="Big success, there's a crawler in your ship. UNLESS THEY ARE ALL DEAD AND IT'S A BUG!" eventsprite="guywithalcohol" />
        </Success>
        <Failure>
          <StatusEffectAction targettag="player">
            <StatusEffect target="This" >
              <Sound file="Content/Items/Weapons/honk.ogg" range="500" volume="1" />
            </StatusEffect>
          </StatusEffectAction>
          <Goto name="checkcrawlerinside" />
        </Failure>
      </CountTargetsAction>
    </ScriptedEvent>

[ubertpendragon]

Ok so:

• For CountTargetsAction, it seems to auto-suceed only if you're using CompareToTarget="capturetarget" MinPercentageRelativeToTarget="30", and IT DOESNT DISPLAY AN ERROR MESSAGE. Replacing it with minamount="1" does not automatically succeed the check.

• For CheckConditionalAction it still auto-succeeds and throws an error message.

    <!-- killmonsters will validate this if crawlers are far enough from the sub (they will get despawned)-->
    <ScriptedEvent identifier="capturelivecrawlereventBUGGED2">
      <SpawnAction speciesname="crawler" TargetTag="capturetarget" amount="3" SpawnLocation="MainPath" offset="500" />
      <TagAction criteria="player" tag="player" />
      <TagAction criteria="hull" tag="playerhull" submarinetype="Player" />
      <Label name="checkcrawlerinside" />
      <WaitAction time="1" />
      <!-- check if a crawler is inside the sub, I also tried  <Conditional InPlayerSubmarine="true" />  -->
      <CheckConditionalAction targettag="capturetarget"  logicaloperator="And">
        <Conditional IsDead="False" />
        <Conditional InPlayerSubmarine="true" />
        <Success>
          <ConversationAction targettag="player" text="Big success, there's a crawler in your ship. UNLESS THEY ARE ALL DEAD AND IT'S A BUG!" eventsprite="guywithalcohol" />
        </Success>
        <Failure>
          <StatusEffectAction targettag="player">
            <StatusEffect target="This" >
              <Sound file="Content/Items/Weapons/honk.ogg" range="500" volume="1" />
            </StatusEffect>
          </StatusEffectAction>
          <Goto name="checkcrawlerinside" />
        </Failure>
      </CheckConditionalAction>
    </ScriptedEvent>

Checks should NOT succeed in any case

[Regalis11]

Thank you for the report! This has now been addressed in our private repo:

• Made CheckConditionalAction fail instead of succeeding if it can't find the specified target. Option to make it succeed instead. I also went through the events in which we use the action, and there were a couple of case where it should succeed even if the target can't be found (traitor events where we're checking whether a target is dead or incapacitated - if the target is totally gone/despawned, they must be dead too and the traitor mission should succeed).
• Made CountTargetsAction fail instead of succeeding if it's trying to compare against the amount of some other target (like, "number of flooded hulls" is at least 30% of the "number of all hulls") and none of that other target can't be found.

The fix will be included in the next unstable build and the upcoming spring update.