Skip to content

Commit

Permalink
Test tf timeout (#55)
Browse files Browse the repository at this point in the history
* Change timeout to seconds

* 1m

* dude

* g

* Add terraform timeouts for node pool

* Add changelog information
  • Loading branch information
nungster authored Jun 21, 2023
1 parent 1ff572a commit 8841377
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
3 changes: 3 additions & 0 deletions node_pool/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# node-pool-v3.8.2
- Added `timeout_create`, `timeout_delete`, and `timeout_update` parameters to provide a way to override the Terraform default timeouts for these actions on `google_container_node_pool` node pool resource.

# node-pool-v3.8.1
- Added `node_locations` parameter to limit a node pool to specific zones. Zones selected must be in the parent clusters region. If left empty nodes will default to their parent clusters zones. **Note: node_locations will not revert to the cluster's default set of zones upon being unset. You must manually reconcile the list of zones with your cluster.

Expand Down
18 changes: 18 additions & 0 deletions node_pool/inputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,21 @@ variable "taint" {
type = map
default = null
}

variable "timeout_create"{
type = string
description = "Override default timeout for CREATE function"
default = "30m"
}

variable "timeout_delete"{
type = string
description = "Override default timeout for DELETE function"
default = "30m"
}

variable "timeout_update"{
type = string
description = "Override default timeout for UPDATE function"
default = "30m"
}
6 changes: 6 additions & 0 deletions node_pool/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,10 @@ resource "google_container_node_pool" "node_pool" {
node_config.0.min_cpu_platform
]
}

timeouts {
create = var.timeout_create
update = var.timeout_update
delete = var.timeout_delete
}
}

0 comments on commit 8841377

Please sign in to comment.