add regression test for leader-broadcast silent-drop bug#311
Merged
Conversation
When a BroadcastedMessage arrives before the leader's VerificationKey, process_broadcasted_message silently skips the embedded OriginalMessage (see leader_broadcast.rs:404-410). The data is lost, and the keys step cannot complete. The regression test processes a Broadcasted envelope before storing the leader's verification key in the receiving BitVMX instance's storage, then asserts that the previously skipped OriginalMessage can be recovered. A companion control test covers the case where the verification key is already present. The failing test captures the missing behavior. Both tests are #[ignore]d and use prepare_bitcoin_guarded to launch bitcoind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a BroadcastedMessage arrives before the leader's VerificationKey, process_broadcasted_message silently skips the embedded OriginalMessage (see leader_broadcast.rs:404-410). The data is lost, and the keys step cannot complete.
The regression test processes a Broadcasted envelope before storing the leader's verification key in the receiving BitVMX instance's storage, then asserts that the previously skipped OriginalMessage can be recovered. A companion control test covers the case where the verification key is already present.
The failing test captures the missing behavior. Both tests are #[ignore]d and use prepare_bitcoin_guarded to launch bitcoind.