Skip to content

Django 5.2 support #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Django 5.2 support #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c93554
Django 5.2 support
kingbuzzman May 21, 2025
a597b76
Updates reqs
kingbuzzman May 21, 2025
dc660ce
updates changelog
kingbuzzman May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ChangeLog
3.3.4 (unreleased)
------------------

- Nothing changed yet.
- Add support for Django 5.2


3.3.3 (2025-02-03)
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ classifiers =
Framework :: Django :: 4.2
Framework :: Django :: 5.0
Framework :: Django :: 5.1
Framework :: Django :: 5.2
Intended Audience :: Developers
License :: OSI Approved :: MIT License
Operating System :: OS Independent
Expand Down
3 changes: 2 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ deps =
mongo: mongomock
# mongomock imports pkg_resources, provided by setuptools.
mongo: setuptools>=66.1.1
django{42,51,main}: Pillow
django{42,51,52,main}: Pillow
django42: Django>=4.2,<5.0
django51: Django>=5.1,<5.2
django52: Django>=5.2,<6
djangomain: Django>5.1,<6.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should probably be bumped too? Otherwise it might be testing the same as above... We might have to revert to downloading from source as there is no 6.0 on PyPI yet:

Suggested change
djangomain: Django>5.1,<6.0
djangomain: https://github.com/django/django/archive/main.tar.gz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I completely agree with your suggestion, I’m not sure this change should be included in this PR. It’s unrelated to the scope of the current work and would be better handled in a separate PR. I’m a strong proponent of keeping PR titles and bodies aligned with their actual changes.

PS. This sounds like a great idea for a contribution from you @browniebroke -wink-wink-

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... Otherwise I'll do it in another PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you're argument makes some sense... However, I'm going to make another one which may also makes sense (I think):

This PR adds support to a new version of Django, and doing so means that "django main" should keep pointing to the next version, which means updating this 😄

Anyway, I'll leave it up to a maintainer to decide. There is a gap in my understanding as to why it was changed away from installing from source in the first place, maybe they can shed some light on that.


setenv =
Expand Down