-
Notifications
You must be signed in to change notification settings - Fork 13
Tutorial text tweaks #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial text tweaks #338
Conversation
|
I reviewed the diff and am good with it. Is this complete? one of us has to run the builder script and make the transcript and I don't see that here, plus I would kind of expected more tweaks in later chapters. So seems worth clarifying whether you're going to want to do more before I land this. |
|
The changes are complete for this PR. I want to do a deeper set of changes in the future but the high-priority ones are all here. I tried running "/fa-tutorial-transcript" and the narrator said it was written to script-output/tutorial-transcript.md but I am unable to find the folder or the file in VS Code search. |
|
Okay I found the script-output folder in the game's folder but now I have a new problem - despite the locale folder having the new version of the chapter texts, the mod is still reading out the old versions and markdown is also using the old versions. |
|
Yeah i could not figure out how to register the updates to the tutorial locale files. I tried restarting the game, restarting the launcher, reloading the mod. I am sure that the new text is currently inside the mod's locale folder. |
|
You need to run build_message_lists.py. to bake it into the locale files first (that's why I asked if this was done--there's supposed to be a bunch of locale file changes and at least one small automatic Lua change). I'm not "hack the game into reading text files" clever. I think it's valuable for you to know how to run it so I encourage you to try, but I will land this later when I am awake and just do it this time. |
|
Oh okay, my bad. If it is useful, I think I had designed the old tutorial system to re-grab from txt fıles every time you open the menu. It has low overhead so you gain this update resilience by doing that. |
|
You can't, the text files aren't valid locale files. There is no additional player-facing overhead to the way we do it now. The text files become something like: Then there's a one tick delay to load the metadata. It mostly works like yours did, just with the metadata key added which lets us get the number, which now can vary between locales, and the compilation step, which stops everyone having to renumber everything. Yours baked it into the locale file by hand and I think forced the same number of steps per locale. I will point out the commit sha to you so that you can see what got built. I didn't forget about this, but I ended up dealing with my health issues over the weekend and so nothing got done. Hopefully today. |
I reviewed the new tutorial text and made some tweaks. Feel free to use them as starting points to do your own tweaks or they can maybe be applied directly. Here they are:
Chapter starts and ends
I made sure that each chapter begins with the reasoning of "This is where we stand, this is what this chapter covers." and most chapters ends with "Now we are considering this problem, which is covered in the next chapter." These navigational sentences already were present in most chapters to various degrees, so the changes are not dramatic.
Chapter 1 tone edits
The chapter 1 is blunt and terse in some places when it says "blind people can't do this". I proposed some edits there to make the reasoning softer and clearer.
Chapter 2 thinking backwards part extended
I extended the logic of the "you have to think backwards" part of chapter 2 so that it begins with the clear end goal of launching a rocket.