Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21.4: "Creating Your First Item" #250

Draft
wants to merge 4 commits into
base: port/1.21.4
Choose a base branch
from

Conversation

RaphProductions
Copy link

Since 1.21.4, Minecraft doesn't try to guess your model's location anymore, and so, we should now add an item description JSON in assets/modid/items, so this pull request aims to point out that in the documentation.

I only added the description for the Suspicious Substance, and not for the other items of the reference mod.

@RaphProductions RaphProductions requested a review from a team as a code owner January 3, 2025 09:20
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 393006f
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6777ac31c567130008daca97
😎 Deploy Preview https://deploy-preview-250--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@its-miroma its-miroma changed the base branch from main to port/1.21.4 January 3, 2025 12:54
@its-miroma its-miroma added correction Something isn't right on a page stage:verification This should be verified new-version Related to a newer version of Minecraft labels Jan 3, 2025
@its-miroma its-miroma added this to the Update to 1.21.4 milestone Jan 3, 2025
@its-miroma its-miroma changed the title Update first-item.md for 1.21.4 Update to 1.21.4: Creating your first item Jan 3, 2025
@its-miroma its-miroma changed the title Update to 1.21.4: Creating your first item Update to 1.21.4: "Creating Your First Item" Jan 3, 2025
@its-miroma its-miroma mentioned this pull request Jan 3, 2025
52 tasks
Copy link
Member

@IMB11 IMB11 Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been created in the wrong folder (1.20.4 instead of latest), we should also be data generating this instead of just placing raw JSON files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@IMB11 IMB11 marked this pull request as draft January 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Something isn't right on a page new-version Related to a newer version of Minecraft stage:verification This should be verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants