-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.21.4: "Creating Your First Item" #250
base: port/1.21.4
Are you sure you want to change the base?
Conversation
Minecraft 1.21.4 doesn't search the model by itself anymore.
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been created in the wrong folder (1.20.4
instead of latest
), we should also be data generating this instead of just placing raw JSON files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
Since 1.21.4, Minecraft doesn't try to guess your model's location anymore, and so, we should now add an item description JSON in
assets/modid/items
, so this pull request aims to point out that in the documentation.I only added the description for the Suspicious Substance, and not for the other items of the reference mod.