Skip to content

Add large attachment syncing #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DennisOchulor wants to merge 5 commits into
base: 26.1
Choose a base branch
from
Open

Add large attachment syncing #5143

DennisOchulor wants to merge 5 commits into from

Conversation

@DennisOchulor
Copy link
Contributor

@DennisOchulor DennisOchulor commented Jan 17, 2026

This PR mainly does two things:

  1. Change ClientboundAttachmentSyncPayload to handle only one attachment. Initial syncs are sent in a bundle packet.
  2. Allow mods to register synced attachments with a configurable max sync size that can go above the vanilla S2C limit.

Supersedes #4996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DennisOchulor