Lightning Polish

.github/workflows/test.yaml

@@ -39,6 +39,46 @@ jobs:
         else
           brew install bitcoin
         fi
+    - name: Install lightningd
+      run: |
+        if [ "${{ matrix.os }}" = "ubuntu-latest" ]; then
+          # Install system dependencies
+          sudo apt-get update
+          sudo apt-get install -y \
+            autoconf \
+            automake \
+            build-essential \
+            git \
+            libtool \
+            python3-dev \
+            python3-pip \
+            libsqlite3-dev \
+            libgmp-dev \
+            libsodium-dev \
+            gettext \
+            protobuf-compiler \
+            libpq-dev \
+            postgresql
+
+          # Install required Python packages
+          pip3 install --user \
+            mako \
+            grpcio-tools \
+            protobuf \
+            pytest \
+            pytest-timeout \
+            psycopg2-binary
+
+          # Clone and build Core Lightning
+          git clone https://github.com/ElementsProject/lightning.git
+          cd lightning
+          git checkout v24.02.1
+          ./configure
+          make
+          sudo make install
+        elif [ "${{ matrix.os }}" = "macos-latest" ]; then
+          brew install core-lightning
+        fi
     - name: Generate coverage report
       run: npm run report:coverage
     - name: Send coverage report

package.json

@@ -54,6 +54,7 @@
     "report:credits": "license-checker --json > reports/credits.json",
     "report:install": "rm -rf node_modules && echo \"\n\" > package-lock.json && echo \"$ npm i\" > reports/install.log && npm i >> reports/install.log",
     "report:legal": "license-checker --json > reports/licenses.json",
+    "report:noisy": "node scripts/analyze-deps.js | tee reports/noisy-deps.txt",
     "report:todo": "grep --exclude-dir=.git --exclude-dir=_book --exclude-dir=assets --exclude-dir=node_modules --exclude-dir=reports --exclude-dir=coverage --exclude-dir=docs -rEI \"TODO|FIXME\" . > reports/TODO.txt",
     "reports": "npm run report:install && npm run make:coverage && npm run report:todo",
     "review:coverage": "npm run make:coverage && http-server -p 8000 reports/coverage",

scripts/analyze-deps.js

@@ -0,0 +1,116 @@
+#!/usr/bin/env node
+
+const { execSync } = require('child_process');
+const path = require('path');
+const fs = require('fs');
+
+// Get current dependencies from package.json
+function getCurrentDependencies () {
+  const packageJson = JSON.parse(fs.readFileSync('package.json', 'utf-8'));
+  const deps = new Set();
+
+  // Combine both regular dependencies and devDependencies
+  Object.keys(packageJson.dependencies || {}).forEach(dep => deps.add(dep));
+  Object.keys(packageJson.devDependencies || {}).forEach(dep => deps.add(dep));
+
+  return deps;
+}
+
+// Get all commits that modified package-lock.json
+function getPackageLockCommits () {
+  const cmd = 'git log --format="%H" -- package-lock.json';
+  return execSync(cmd, { encoding: 'utf-8' })
+    .trim()
+    .split('\n');
+}
+
+// Get package-lock.json content at a specific commit
+function getPackageLockAtCommit (commit) {
+  try {
+    const cmd = `git show ${commit}:package-lock.json`;
+    const content = execSync(cmd, { encoding: 'utf-8' });
+    return JSON.parse(content);
+  } catch (err) {
+    // Skip if package-lock.json didn't exist at this commit
+    return null;
+  }
+}
+
+// Extract all package versions from package-lock
+function extractPackageVersions (lockfile) {
+  if (!lockfile || !lockfile.packages) return new Map();
+
+  const versions = new Map();
+  for (const [pkg, info] of Object.entries(lockfile.packages)) {
+    if (pkg === '') continue; // Skip root package
+    const name = pkg.replace('node_modules/', '');
+    versions.set(name, info.version);
+  }
+  return versions;
+}
+
+// Track version changes between commits
+function analyzePackageUpdates () {
+  const commits = getPackageLockCommits();
+  const updates = new Map(); // package -> update count
+  let prevVersions = new Map();
+  const currentDeps = getCurrentDependencies();
+
+  for (const commit of commits) {
+    const lockfile = getPackageLockAtCommit(commit);
+    if (!lockfile) continue;
+
+    const currentVersions = extractPackageVersions(lockfile);
+
+    // Compare with previous versions
+    for (const [pkg, version] of currentVersions) {
+      // Only track updates for current dependencies
+      if (!currentDeps.has(pkg)) continue;
+
+      const prevVersion = prevVersions.get(pkg);
+      if (prevVersion && prevVersion !== version) {
+        updates.set(pkg, (updates.get(pkg) || 0) + 1);
+      }
+    }
+
+    prevVersions = currentVersions;
+  }
+
+  return updates;
+}
+
+// Main execution
+try {
+  console.log('Analyzing package update frequency...\n');
+
+  const updates = analyzePackageUpdates();
+
+  // Sort packages by update frequency
+  const sortedUpdates = [...updates.entries()]
+    .sort(([, a], [, b]) => b - a)
+    .slice(0, 25); // Get top 25
+
+  if (sortedUpdates.length === 0) {
+    console.log('No updates found for current dependencies.');
+    process.exit(0);
+  }
+
+  // Calculate max lengths for formatting
+  const maxNameLength = Math.max(...sortedUpdates.map(([name]) => name.length));
+  const maxCountLength = Math.max(...sortedUpdates.map(([, count]) => String(count).length));
+
+  // Print header
+  console.log('Most Frequently Updated Current Dependencies:');
+  console.log('═'.repeat(maxNameLength + maxCountLength + 7));
+
+  // Print results in a formatted table
+  sortedUpdates.forEach(([pkg, count], index) => {
+    const position = `${index + 1}.`.padEnd(3);
+    const name = pkg.padEnd(maxNameLength);
+    const updates = String(count).padStart(maxCountLength);
+    console.log(`${position} ${name} │ ${updates} updates`);
+  });
+} catch (error) {
+  console.error('Error analyzing package updates:', error.message);
+  process.exit(1);
+} 

services/bitcoin.js

@@ -1228,7 +1228,7 @@ class Bitcoin extends Service {
 
   /**
    * Creates an unsigned Bitcoin transaction.
-   * @param {Object} options 
+   * @param {Object} options Options for the transaction.
    * @returns {ContractProposal} Instance of the proposal.
    */
   async _createContractProposal (options = {}) {
@@ -1583,7 +1583,7 @@ class Bitcoin extends Service {
     }
   }
 
-  async _waitForBitcoind (maxAttempts = 10, initialDelay = 2000) {
+  async _waitForBitcoind (maxAttempts = 32, initialDelay = 2000) {
     if (this.settings.debug) console.debug('[FABRIC:BITCOIN]', 'Waiting for bitcoind to be ready...');
     let attempts = 0;
     let delay = initialDelay;