-
Notifications
You must be signed in to change notification settings - Fork 34
Reliability Improvements, Documentation Cleanup #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 59.89% 63.10% +3.21%
==========================================
Files 65 64 -1
Lines 15812 16722 +910
Branches 0 1 +1
==========================================
+ Hits 9470 10552 +1082
+ Misses 6342 6170 -172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve reliability and clean up documentation by removing outdated and unused code as well as updating configuration and requirements. Key changes include the removal of several wallet functions and related tests, refactoring of type instantiations (e.g., switching from State to Actor), and updates to testing timeouts and package configuration.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| types/wallet.js | Removed multiple outdated wallet functions and debug logs |
| types/store.js | Switched instantiation from State to Actor, potentially affecting API usage |
| types/key.js | Updated key derivation configuration logic |
| types/fabric.js | Removed unused components (e.g., App, Ledger, Scribe, Vector) |
| tests/fabric.scribe.js | Removed tests related to the now-removed Scribe component |
| tests/fabric.ledger.js | Removed tests for Ledger functionality |
| tests/bitcoin/service.js | Adjusted timeouts and added local instance cleanup, with one test skipped |
| reports/TODO.txt | Removed obsolete TODO items |
| package.json | Removed dependency and added a new fixtures entry |
| REQUIREMENTS.md | Updated system requirements and network bandwidth recommendations |
General improvements to service management, removal of various old assets.