Skip to content

Conversation

@martindale
Copy link
Member

General improvements to service management, removal of various old assets.

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 74.79407% with 153 lines in your changes missing coverage. Please review.

Project coverage is 63.10%. Comparing base (868a087) to head (48fbe51).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
services/bitcoin.js 65.83% 109 Missing ⚠️
services/zmq.js 67.18% 21 Missing ⚠️
types/key.js 88.98% 13 Missing ⚠️
types/filesystem.js 89.47% 4 Missing ⚠️
types/message.js 87.50% 3 Missing ⚠️
types/peer.js 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   59.89%   63.10%   +3.21%     
==========================================
  Files          65       64       -1     
  Lines       15812    16722     +910     
  Branches        0        1       +1     
==========================================
+ Hits         9470    10552    +1082     
+ Misses       6342     6170     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martindale martindale requested a review from Copilot May 15, 2025 00:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve reliability and clean up documentation by removing outdated and unused code as well as updating configuration and requirements. Key changes include the removal of several wallet functions and related tests, refactoring of type instantiations (e.g., switching from State to Actor), and updates to testing timeouts and package configuration.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types/wallet.js Removed multiple outdated wallet functions and debug logs
types/store.js Switched instantiation from State to Actor, potentially affecting API usage
types/key.js Updated key derivation configuration logic
types/fabric.js Removed unused components (e.g., App, Ledger, Scribe, Vector)
tests/fabric.scribe.js Removed tests related to the now-removed Scribe component
tests/fabric.ledger.js Removed tests for Ledger functionality
tests/bitcoin/service.js Adjusted timeouts and added local instance cleanup, with one test skipped
reports/TODO.txt Removed obsolete TODO items
package.json Removed dependency and added a new fixtures entry
REQUIREMENTS.md Updated system requirements and network bandwidth recommendations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants