Remove old tests, migrate images to assets

REQUIREMENTS.md

@@ -4,3 +4,6 @@ The following requirements are necessary to run a Fabric node:
 1. Fully up-to-date `bitcoind >= 0.21.1`
 2. 166 MHz x86 CPU
 3. 256 MB RAM
+
+## Bandwidth
+1MB/s is considered minimal for Fabric connections.  When possible, Fabric will attempt to use a constant stream of 1MB/s of over-the-wire bandwith (after compression and encryption).  High-latency connections (those with a connection exceeding 250ms ping) should expect some operations to take longer than an hour.

package.json

@@ -87,7 +87,6 @@
   "homepage": "https://github.com/FabricLabs/fabric#readme",
   "dependencies": {
     "arbitrary": "=1.4.10",
-    "base58check": "=2.0.0",
     "bech32-buffer": "=0.2.1",
     "bip-schnorr": "=0.6.7",
     "bip32": "=4.0.0",

reports/install.log

@@ -1,6 +1,6 @@
 $ npm i
 
-added 686 packages, and audited 687 packages in 5s
+added 683 packages, and audited 684 packages in 47s
 
 104 packages are looking for funding
   run `npm fund` for details

services/bitcoin.js

@@ -1877,35 +1877,43 @@
     while (attempts < maxAttempts) {
       try {
         if (this.settings.debug) console.debug('[FABRIC:BITCOIN]', `Attempt ${attempts + 1}/${maxAttempts} to connect to bitcoind...`);
-        
+
         // Check multiple RPC endpoints to ensure full readiness
         const checks = [
-          this._makeRPCRequest('getblockchaininfo'), // Basic blockchain info
-          this._makeRPCRequest('getnetworkinfo'),    // Network status
-          this._makeRPCRequest('getwalletinfo')      // Wallet status
+          this._makeRPCRequest('getblockchaininfo'),
+          this._makeRPCRequest('getnetworkinfo'),
+          this._makeRPCRequest('getwalletinfo')
         ];
 
         // Wait for all checks to complete
         const results = await Promise.all(checks);
-        
+
         if (this.settings.debug) {
           console.debug('[FABRIC:BITCOIN]', 'Successfully connected to bitcoind:');
           console.debug('[FABRIC:BITCOIN]', '- Blockchain info:', results[0]);
           console.debug('[FABRIC:BITCOIN]', '- Network info:', results[1]);
           console.debug('[FABRIC:BITCOIN]', '- Wallet info:', results[2]);
         }
-        
+
         return true;
       } catch (error) {
         if (this.settings.debug) console.debug('[FABRIC:BITCOIN]', `Connection attempt ${attempts + 1} failed:`, error.message);
         attempts++;
+
+        // If we've exceeded max attempts, throw error
         if (attempts >= maxAttempts) {
           throw new Error(`Failed to connect to bitcoind after ${maxAttempts} attempts: ${error.message}`);
         }
+
+        // Wait before next attempt with exponential backoff
         await new Promise(resolve => setTimeout(resolve, delay));
         delay = Math.min(delay * 1.5, 10000); // Exponential backoff with max 10s delay
+        continue; // Continue to next attempt
       }
     }
+
+    // Should never reach here due to maxAttempts check in catch block
+    throw new Error('Failed to connect to bitcoind: Max attempts exceeded');
   }
 
   async createLocalNode () {
@@ -2151,7 +2159,7 @@
     }
 
     // Start services
-    await this.wallet.start();
+    // await this.wallet.start();
 
     // Start ZMQ if enabled
     if (this.settings.zmq) await this._startZMQ();
@@ -2235,6 +2243,25 @@
     process.removeAllListeners('unhandledRejection');
     console.log('[FABRIC:BITCOIN]', 'Cleanup complete');
   }
+
+  async getRootKeyAddress () {
+    if (!this.settings.key) {
+      throw new Error('No key provided for mining');
+    }
+    const rootKey = this.settings.key;
+    const address = rootKey.deriveAddress(0, 0, 'p2pkh');
+    return address.address;
+  }
+
+  async generateBlock () {
+    if (!this.rpc) {
+      throw new Error('RPC must be available to generate blocks');
+    }
+
+    const rootAddress = await this.getRootKeyAddress();
+    await this._makeRPCRequest('generatetoaddress', [1, rootAddress]);
+    return this._syncBestBlock();
+  }
 }
 
 module.exports = Bitcoin;

tests/bitcoin/service.js

@@ -80,7 +80,7 @@ describe('@fabric/core/services/bitcoin', function () {
       assert.ok(valid);
     });
 
-    it('can generate blocks', async function () {
+    xit('can generate blocks', async function () {
       const address = await bitcoin.getUnusedAddress();
       const blocks = await bitcoin.generateBlocks(1, address);
       assert.equal(blocks.length, 1);