feature: type/store.js leveldb integration #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindale
requested changes
Oct 3, 2022
Member
martindale
left a comment
martindale
left a comment
There was a problem hiding this comment.
Some of the methods added to Store can be migrated to Identity, Environment, or other — will work with @victorwu to get everything in appropriate places
| "jayson": "4.0.0", | ||
| "json-pointer": "0.6.2", | ||
| "level": "7.0.1", | ||
| "level": "^8.0.0", |
Member
There was a problem hiding this comment.
Remove the caret to pin to this version (prevents dependency changes unless explicitly desired)
|
|
||
| /** | ||
| * Insert identity into store of specified account index. | ||
| * @param {IIdentity} identity array of identities generated from account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Summary
This feature integrates leveldb database storage functions into types/store. This would enable further account and identity storage, allowing users to have better profile management when accessing various fabric applications. Functions in fabric-browser-extension have also been migrated to use types/store in @fabric/core.