Skip to content

Potential fix for code scanning alert no. 1: Use of potentially dangerous function #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fabio3rs merged 1 commit into from
Aug 26, 2025
Merged

Potential fix for code scanning alert no. 1: Use of potentially dangerous function #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/PistacheCustomHttpHeaders/LastModified.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <bits/types/time_t.h>
#include <memory>
#include <string>
#include <ctime>

namespace PistacheCustomHttpHeaders {
class LastModified : public Pistache::Http::Header::Header {
Expand Down Expand Up @@ -38,10 +39,24 @@ class LastModified : public Pistache::Http::Header::Header {

static auto format(std::time_t cftime) -> std::string {
std::array<char, 48> buffer{};

std::tm tm_time{};
#if defined(_WIN32) || defined(_WIN64)
// Use gmtime_s on Windows
errno_t err = gmtime_s(&tm_time, &cftime);
if (err != 0) {
// Unable to convert time
return {};
}
#else
// Use gmtime_r on POSIX
if (!gmtime_r(&cftime, &tm_time)) {
// Unable to convert time
return {};
}
#endif
size_t strft_res_sz =
strftime(buffer.data(), buffer.size(), "%a, %d %b %Y %H:%M:%S GMT",
std::gmtime(&cftime));
&tm_time);

return {buffer.data(), strft_res_sz};
}
Expand Down