Skip to content

Conversation

@bputigny
Copy link

With the indent error write_workpackage_information is called for every workpackage run instead of just once.
With this fix I went from 96.305 to 5.682 secs for a benchmark creating 336 workpackages.

@thobreuer
Copy link
Collaborator

Thank you for your contribution! I hope you won't be too disappointed by the reason why we decided not to merge it:
The current indentation in the code improves JUBE's internal data persistence and is necessary for the procs attribute of the step to function correctly. We are aware of this performance penalty, but we didn't see it before publishing the release because our test suite didn't have a test that created many work packages at the time.
However, we have been working on a solution for some time:
To improve runtime performance (especially for high work package counts), data persistence and consistency, we are replacing the workpackage.xml and other files with a database. The function that is called in the line that you modified writes parts of JUBE's internal state to the aforementioned file and will be replaced by updating entries in the database. As this involves changing the core elements and principles of the JUBE code, which have not been modified for a long time, we require additional time to publish it as a beta release, which will also introduce new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants