Skip to content

Conversation

@jaybosamiya
Copy link
Member

@jaybosamiya jaybosamiya commented May 25, 2019

Closes #107.

Supports the user choosing whether they want this new feature.

@jaybosamiya jaybosamiya requested a review from cpitclaudel May 25, 2019 00:10
@jaybosamiya
Copy link
Member Author

jaybosamiya commented May 25, 2019

This is very much a hack (I just check for whether the path+"i" exists), so I am not sure whether we should merge this in; however, it is a starting point for building the feature in, which is why I opened up a PR for it.

@cpitclaudel I would strongly appreciate your thoughts on this. Thanks :)

Copy link
Contributor

@cpitclaudel cpitclaudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I think what would be ideal would be to refactor this to reuse part of the implementation of fstar-visit-interface-or-implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fstar-jump-to-definition on a module should jump to the fsti if it exists

2 participants