-
Notifications
You must be signed in to change notification settings - Fork 244
Loading dependences on the fly #4060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikswamy
wants to merge
42
commits into
master
Choose a base branch
from
_nik_load_deps_fly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,372
−2,766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arations for interactive mode
…ng dependences on the fly
… with fly_deps for IDE mode
…re; admitting a couple of proofs in X64.Vale.Decls that take ages, though they succeed
…tly from source (without checked file) with fly_deps on
Collaborator
Author
|
FYI, fly_deps also works in Karamel and in pulse (with some small changes to ordering for friend declarations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
--ext fly_deps, an option to scan and load dependences of a module incrementally, just before a single ast declaration is type checked, rather than scanning and loading a module's dependences up front, before the module is checked.This is especially motivated by wanting to fix a wart in the interactive mode, where adding a dependence while working on a module required restarting the IDE.
A change in behavior with fly_deps is that modules come in scope only at their first reference. So, for example,
the typeclass instances, SMT patterns etc. exported by B are not in scope for checking
let f = e.Another is that
frienddeclarations must be the first declared dependence on a module. Otherwise, we report errors like this:--ext fly_depsis enabled throughout the F* repo, including in .fst.json config files for VS code. I expect it will become the default behavior at some point, but having it under a flag is to limit regressions in other repositories, until we all get a chance to use this feature and shake out any remaining issues.