-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all visualizations with dds.js #291
base: master
Are you sure you want to change the base?
Conversation
Current coverage is
|
@Gerrrr I think codacy will complain a lot less if you name your |
@FRosner done |
@Gerrrr except for the one remaining issue in |
@@ -44,8 +44,6 @@ | |||
*/ | |||
define(function(require) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shiiiieet codacy... Are you never happy? :D
Shall we lock her up somewhere, @Gerrrr ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it actually has a point - we don't use require in this function. I'll fix it later today.
@FRosner, PR is ready for review, please ignore codacy complaints. |
Thanks for the pull request @Gerrrr. After executing the Canvas Size (L: 14, 15, ...)
Dashboard Blocking the UI (L: 19)
Summary Composite Overplotting (L: 20)
Heatmap with NaN not Displayed (L: 21)
Scatterplot (L: 26)
Key Value Pairs (L: 27)
Table Not Drawn (L: 97)
Visualization Title Positioning
Graph Buttons Wrong (L: 14)
Graph Redrawing
Overall Performance
|
@@ -0,0 +1,21 @@ | |||
define(function(require) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: "define" is not defined.
I fixed the issues you mentioned above. Can you please review it again? |
I released DDQ 3.0.0 today and will take a look at it in the next days @Gerrrr. Thanks! |
Solution for: #289