Dev #35
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,25 +2,25 @@ name: Release | |
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: release-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| if: github.ref == 'refs/heads/master' | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| outputs: | ||
| new_version: ${{ steps.version.outputs.new_version }} | ||
| version_number: ${{ steps.version.outputs.version_number }} | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -31,167 +31,112 @@ jobs: | |
| - name: Setup Bun | ||
| uses: oven-sh/setup-bun@v2 | ||
| with: | ||
| bun-version: 1.3.10 | ||
|
|
||
| - name: Install dependencies | ||
| run: bun install --frozen-lockfile | ||
|
|
||
| - name: Resolve version | ||
| id: version | ||
| run: | | ||
| VERSION=$(node -p "require('./package.json').version") | ||
| if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-[A-Za-z0-9.-]+)?$ ]]; then | ||
| echo "Invalid package.json version: $VERSION" | ||
| exit 1 | ||
| fi | ||
| echo "new_version=v$VERSION" >> "$GITHUB_OUTPUT" | ||
| echo "version_number=$VERSION" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Verify release metadata | ||
| run: | | ||
| bun run version:check | ||
| bun run docs:validate | ||
| VERSION="${{ steps.version.outputs.version_number }}" | ||
| grep -F "## [${VERSION}]" CHANGELOG.md >/dev/null | ||
|
|
||
| - name: Type check | ||
| run: bun run tsc --noEmit | ||
|
|
||
| - name: Run test suite | ||
| run: bun test | ||
|
|
||
| - name: Build application | ||
| run: bun run build | ||
|
|
||
| - name: Create release archive | ||
| run: | | ||
| mkdir -p release | ||
|
|
||
| tar -czf release/igloo-server-${{ steps.version.outputs.version_number }}-src.tar.gz \ | ||
| --exclude=node_modules \ | ||
| --exclude=.git \ | ||
| --exclude=release \ | ||
| --exclude=static/app.js \ | ||
| --exclude=static/styles.css \ | ||
| . | ||
|
|
||
| tar -czf release/igloo-server-${{ steps.version.outputs.version_number }}.tar.gz \ | ||
| --exclude=node_modules \ | ||
| --exclude=.git \ | ||
| --exclude=release \ | ||
| --exclude=frontend \ | ||
| src static package.json bun.lock tsconfig.json Dockerfile compose.yml README.md LICENSE docs/openapi | ||
|
|
||
| - name: Create release tag | ||
| run: | | ||
| TAG="${{ steps.version.outputs.new_version }}" | ||
| git fetch --tags origin | ||
| if git rev-parse -q --verify "refs/tags/${TAG}" >/dev/null; then | ||
| echo "Tag ${TAG} already exists, skipping tag creation" | ||
| else | ||
| git tag "${TAG}" | ||
| git push origin "${TAG}" | ||
| fi | ||
|
AustinKelsay marked this conversation as resolved.
|
||
|
|
||
| - name: Create GitHub release and upload assets | ||
| uses: softprops/action-gh-release@v2 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| tag_name: ${{ steps.version.outputs.new_version }} | ||
| name: Release ${{ steps.version.outputs.new_version }} | ||
| body: | | ||
| ## Changes in ${{ steps.version.outputs.new_version }} | ||
|
|
||
| See [CHANGELOG.md](https://github.com/FROSTR-ORG/igloo-server/blob/master/CHANGELOG.md) for full details. | ||
|
|
||
| ### Installation | ||
|
|
||
| **Docker (Recommended)**: | ||
| ```bash | ||
| docker pull ghcr.io/frostr-org/igloo-server:${{ steps.version.outputs.version_number }} | ||
| ``` | ||
|
|
||
| **From Source**: | ||
| ```bash | ||
| curl -L https://github.com/FROSTR-ORG/igloo-server/archive/${{ steps.version.outputs.new_version }}.tar.gz | tar -xz | ||
| cd igloo-server-${{ steps.version.outputs.version_number }} | ||
| bun install | ||
| bun run build | ||
| bun run start | ||
| ``` | ||
| draft: false | ||
| prerelease: false | ||
| files: | | ||
| ./release/igloo-server-${{ steps.version.outputs.version_number }}-src.tar.gz | ||
| ./release/igloo-server-${{ steps.version.outputs.version_number }}.tar.gz | ||
|
|
||
| docker: | ||
| runs-on: ubuntu-latest | ||
| needs: release | ||
| permissions: | ||
| packages: write | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: refs/tags/${{ needs.release.outputs.new_version }} | ||
|
Comment on lines
+132
to
+139
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: cat -n .github/workflows/release.yml | head -160 | tail -50Repository: FROSTR-ORG/igloo-server Length of output: 1977 🏁 Script executed: # Get the full context of the docker job
sed -n '100,150p' .github/workflows/release.ymlRepository: FROSTR-ORG/igloo-server Length of output: 1682 🏁 Script executed: # Check if there are any other permission patterns in the file
grep -n "permissions:" .github/workflows/release.yml -A 3Repository: FROSTR-ORG/igloo-server Length of output: 227 🌐 Web query:
💡 Result:
permissions:
contents: readOtherwise the checkout step can fail because any permission you don’t list is set to Notes:
Citations:
🏁 Script executed: # Check if there are any comments or documentation in the workflow file itself
grep -i "permission\|token\|contents\|read" .github/workflows/release.yml | head -20Repository: FROSTR-ORG/igloo-server Length of output: 438 Restore repository read permission in the Docker job. Job-level 🔧 Minimal fix docker:
runs-on: ubuntu-latest
needs: release
permissions:
+ contents: read
packages: write🤖 Prompt for AI Agents |
||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
@@ -219,7 +164,7 @@ jobs: | |
| org.opencontainers.image.version=${{ needs.release.outputs.version_number }} | ||
| org.opencontainers.image.revision=${{ github.sha }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
|
|
||
| - name: Build and push Umbrel Docker image | ||
| uses: docker/build-push-action@v5 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
git ls-files ".github/workflows/*.yml"Repository: FROSTR-ORG/igloo-server
Length of output: 154
🏁 Script executed:
cat -n ".github/workflows/release.yml"Repository: FROSTR-ORG/igloo-server
Length of output: 7399
Don't trigger release workflow on every push to master without versioning changes.
Every push to
masterwill execute the release job. Whenpackage.jsonhasn't changed, the version is reused from the previous release. At lines 89–90, tag creation is skipped if the tag already exists, but the job continues executing: it builds artifacts, and at lines 96–127 the release action creates or updates a release for that existing tag. This means multiple commits can publish under the same version tag—each overwriting the previous release's artifacts—making it impossible to track which commit corresponds to a released version.🤖 Prompt for AI Agents