Remove multi-version wrappers and 1.12.2 support; migrate shared code to direct 1.8.9 APIs#121
Remove multi-version wrappers and 1.12.2 support; migrate shared code to direct 1.8.9 APIs#121
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39695f0851
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (Score score : filtered) { | ||
| String name = ScorePlayerTeam.formatPlayerName(scoreboard.getPlayersTeam(score.getPlayerName()), score.getPlayerName()); | ||
| String line = name + ": " + score.getScorePoints(); | ||
| lines.add(line); |
There was a problem hiding this comment.
Honor the Scoreboard.score setting before appending points
The Scoreboard module exposes a score toggle (see Scoreboard.score in features/impl/interfaces/Scoreboard) that previously controlled whether score points were rendered; in the old wrapper path the points were only drawn when that setting was enabled. The new rendering path always appends ": " + score.getScorePoints() to each line, so disabling the setting no longer hides points. This is a behavior regression for users who turn off the score display, and it will make the scoreboard ignore the module’s own setting in all worlds that display an objective.
Useful? React with 👍 / 👎.
Motivation
Description
v1.12.2module, and addedshared/java/top/fpsmaster/Constants.javawithEDITION = "1.8.9"andVERSION = "v1.8.9"to scope the build to 1.8.9.Wrappers,MinecraftAPI, provider registries and wrapper helper classes with direct vanilla 1.8.9Minecraft/mccalls across shared code (examples:Utility,Module,Render2DUtils,Render3DUtils, many UI components and feature implementations).Tessellator/WorldRendererand switched from wrapper AxisAlignedBB/model types to vanillaAxisAlignedBB/BlockPoswhere appropriate; simplified feature implementations (scoreboard, hitboxes, particles, motion blur shader handling, TNT timer, FreeLook, etc.) to call vanilla APIs directly.Performancefallbacks.Testing
rg/sed) and applied code changes across ~268 files, then staged and committed the changes successfully withgit commit(commit message: "Remove multi-version wrappers and 1.12.2 module").shared/java/top/fpsmaster/Constants.java,shared/java/top/fpsmaster/utils/Utility.java,shared/java/top/fpsmaster/ui/screens/mainmenu/MainMenu.java,v1.8.9/src/main/java/top/fpsmaster/forge/Mod.java) to verify replacements and deletions; those checks completed without errors.Codex Task