Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted changes #516

Merged
merged 25 commits into from
Jan 5, 2025
Merged

Assorted changes #516

merged 25 commits into from
Jan 5, 2025

Conversation

zapta
Copy link
Collaborator

@zapta zapta commented Jan 3, 2025

Details are in the specific commits.

Highlights:

  • Apio now check that the home dir path is absolute (e.g. /foo/bar or ~/.apio2, but not foo/bar/). This applies to users that use APIO_HOME_DIR.
  • *Now restricting apio home dir path to ascii characters only. This fixes the gowin integration test on windows. Per this issue [For discussion] Disallow unicode characters in apio home dir? #515
  • 'apio sim' without testbench specification now runs the default testbench, either the value of 'default-testbench' in apio.ini or the testbench file in the project if there is exactly one. Otherwise it prints an error message.
  • Apio commands that use packages (e.g. apio build) now fix broken packages and install missing packges automatically on the fly. (which makes 'apio packages fix' and 'apio packages install' unnecessary for most users.).
  • Removed the 'tools-' prefix from packages folders name. The packages folders name are now identical to the package name.

zapta added 13 commits January 2, 2025 08:25
… without a testbench specification, it will use the testbench specified in apio.ini using 'default-testbench' or if not specified, and the project has exactly single project it will pick that testbench. Otherwise it's a fatal error.
… apio project dir path which can contain non ascii characters. More details here FPGAwars#515
…packages. No need anymore to run 'apio packages install' when installing apio.

FPGAwars#517
…esn't match distribution.json, and 'apio packages fix' deletes them.
…all automatically missing packages but also fix broken ones, similar to 'apio packages fix'.
zapta added 11 commits January 4, 2025 00:19
…e tests failed on a slow windows computer I used.
…alled packages'. No change in functionality.
…t of uninentional uninstallation of packages is minimal, especially with the new auto installation by commands such as 'apio build'.
…rectory of each installed package matches its name. Motivation is simplificty.
…he path it has is absolute. Discussion here FPGAwars#522.  Also added expansion of the home dir marker and system env vars such as in APIO_HOME_DIR="~/foor/$XYZ"
@zapta
Copy link
Collaborator Author

zapta commented Jan 5, 2025

Hi @cavearr, can you review and accept?

From icestudio perspetive, APIO_HOME_DIR must satisfy:

  • No spaces
  • Only ASCII characters [33, 127]
  • Absolute path.

@cavearr
Copy link
Member

cavearr commented Jan 5, 2025

thanks @zapta ! in Spain today and tomorrow are christmas holidays, after tomorrow i'm reply all pending messages and go on!

@cavearr cavearr merged commit 48007bf into FPGAwars:develop Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants