-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted changes #516
Merged
Merged
Assorted changes #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge in functionality.
… without a testbench specification, it will use the testbench specified in apio.ini using 'default-testbench' or if not specified, and the project has exactly single project it will pick that testbench. Otherwise it's a fatal error.
… apio project dir path which can contain non ascii characters. More details here FPGAwars#515
…or that spans multiple lines.
…ective commands. No functional change.
…packages. No need anymore to run 'apio packages install' when installing apio. FPGAwars#517
…esn't match distribution.json, and 'apio packages fix' deletes them.
…all automatically missing packages but also fix broken ones, similar to 'apio packages fix'.
…' with env var APIO_DEBUG defined.
…e tests failed on a slow windows computer I used.
…alled packages'. No change in functionality.
…e package in the local drive.
…t of uninentional uninstallation of packages is minimal, especially with the new auto installation by commands such as 'apio build'.
…rectory of each installed package matches its name. Motivation is simplificty.
…he path it has is absolute. Discussion here FPGAwars#522. Also added expansion of the home dir marker and system env vars such as in APIO_HOME_DIR="~/foor/$XYZ"
Hi @cavearr, can you review and accept? From icestudio perspetive, APIO_HOME_DIR must satisfy:
|
thanks @zapta ! in Spain today and tomorrow are christmas holidays, after tomorrow i'm reply all pending messages and go on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the specific commits.
Highlights:
/foo/bar
or~/.apio2
, but notfoo/bar/
). This applies to users that useAPIO_HOME_DIR
.