Skip to content

fix/model_loading_crash_issue #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengzz-coding wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix/model_loading_crash_issue #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions validator/modules/llm_judge/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,19 +914,20 @@ def validate(self, data: LLMJudgeInputData, **kwargs) -> LLMJudgeMetrics:

try:
self._load_model(data.hg_repo_id, data.revision, data.max_params)
# Stage 1: Generate all responses
logger.info("Stage 1: Generating all conversations for evaluation...")
all_conversations = self._load_jsonl_conversations(
data.base_model, eval_file, data.eval_args, data.context_length
)
except InvalidModelParametersException as e:
# lowest possible reward for invalid model parameters
logger.info(f"Invalid model parameters: {e}")
logger.error(f"Invalid model parameters: {e}")
return LLMJudgeMetrics(score=LOWEST_POSSIBLE_SCORE)
except Exception as e:
logger.error(f"Generate conversations error: {e}")
return LLMJudgeMetrics(score=LOWEST_POSSIBLE_SCORE)

# Stage 1: Generate all responses
logger.info("Stage 1: Generating all conversations for evaluation...")
all_conversations = self._load_jsonl_conversations(
data.base_model, eval_file, data.eval_args, data.context_length
)

# Load evaluation arguments

max_eval_try = data.eval_args.get(
"eval_require", 3
) # Default max evaluation tries
Expand Down