Fix crawler crash when UserID cookie is missing#26
Open
Jisevind wants to merge 2 commits into
Open
Conversation
Add _sanitize_filename function to replace invalid filename characters with underscores when gathering assets. This prevents filesystem errors when downloading files with names containing special characters like <, >, :, ", /, \, |, ?, or *.
…ception The UserID check was causing failures when cookies didn't contain the UID, but this value appears to be unused in the crawling process. Changed to log a warning instead of raising an exception to allow crawling to continue.
Owner
|
Thanks. I may have time to test it this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in the crawler when the UserID cookie is missing.
Instead of throwing an exception, the crawler now safely ignores the
missing value and continues execution.
Also includes filename sanitization to avoid invalid characters.
Tested locally.