-
-
Notifications
You must be signed in to change notification settings - Fork 40
Encompassing DeRham element #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jmv2009
wants to merge
2
commits into
FEniCS:main
Choose a base branch
from
jmv2009:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright (c) 2024 Johannes M. Vogels | ||
// FEniCS Project | ||
// SPDX-License-Identifier: MIT | ||
|
||
#pragma once | ||
|
||
#include "cell.h" | ||
#include "element-families.h" | ||
#include "finite-element.h" | ||
#include <concepts> | ||
|
||
namespace basix::element | ||
{ | ||
/// Create a finite element on cell with given degree | ||
/// @param[in] celltype The cell type | ||
/// @param[in] degree The degree of the element | ||
/// @param[in] form -1,0,1,2,3 : de Rahm complex form | ||
/// @param[in] trimmed : P- instead of P based | ||
/// @param[in] tensor : instead of serendipity | ||
/// @param[in] tiniesttensor : instead of full | ||
/// @param[in] rotated2D : Curl Div instead of Grad Curl complex for 2D | ||
/// @return A finite element | ||
template <std::floating_point T> | ||
FiniteElement<T> create_DeRham_element(cell::type celltype, | ||
int degree, | ||
int form, | ||
bool trimmed, | ||
bool tensor, | ||
bool tiniesttensor, | ||
bool rotated2D | ||
); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd strongly favour using an enum here rather than a long list of bools. Would it be helpful in the short term to add a Python utility function to create elements in this way? That could be added very quickly if so