Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slight inaccuracy in test 3_F7_05_2 #4288

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

OFFTKP
Copy link
Contributor

@OFFTKP OFFTKP commented Jan 21, 2025

Needs cwd/cdq/cqo to sign extend into RDX/EAX/AX for imul to do what is described, for example in

; Negative * Negative
mov ax, -128
imul word [r8 + 8 * 0 + 0]
ofcfmerge

dx:ax is not negative, unless if we do cwd

Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the improvement!

@Sonicadvance1 Sonicadvance1 merged commit 42c931c into FEX-Emu:main Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants