Windows: Removes opaque wine_builtin binary #4268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead generate it with an echo command which is easier to see what it is doing. It's a trivial file that is just a string and 16 zeroes. Brought up by FEX-Emu#4267
|
-1 on this. Generating this file at build-time doesn't really add anything but increases build script complexity, and the issue reporter mentioned it's not a real issue for auditability:
Instead of moving the file contents to CMake, auditability would probably benefit more from a comment explaining what the file is actually used for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead generate it with an echo command which is easier to see what it is doing. It's a trivial file that is just a string and 16 zeroes.
Brought up by #4267