refactor GetMessageID to enhance the performance #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides generating the message ID, the method
GetMessageIDupdates the Path/MessageID/MessageType mapping for every API call (to make it known to the request handler).This seems inefficient and redundant, as every message is already registered in advance in the generated
init()in its API file.The patch uses these pre-registered messages to fill the
msgMapByPathmap during the connection procedure, so it does not have to be done again, andGetMessageIDcan do only what it says.The
msgIDmap seems to be unused.Signed-off-by: Vlado Lavor [email protected]