design-pack: second plugin with three design-craft skills - #46
Merged
Conversation
ui-design-craft / motion-craft / design-review-gate, mined from a 14-repo survey (MIT text sources with notices; ideas-only elsewhere). The design-contract evidence rules land in design-review-gate per the dual-model consultation (grok-4.5 high + gpt-5.6-sol max, both converged on no-fourth-skill). checks.py extended to N marketplace plugins (fail-closed; negative-tested on a planted version mismatch). Probe round on private fixtures: A/B/C PASS bare-vs-ruled, D NULL (under-armed trap, recorded); round-0 voided for a leaked answer key. opus-pack alpha-0.1.15; design-pack 0.1.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MF: Apple-HIG bezier relabeled to kCAMediaTimingFunctionDefault/CSS ease (HIG publishes no numeric curves - now itself a listed mislabel); WCAG sentence rewritten to true AA floors (placeholder/overlay text 4.5:1, secondary body text 4.5:1 both modes); 40-60% scrim number replaced with the Material 32% vendor anchor (traced to a declared-unmined repo - survey debris, reworded out); touch audit MIN=48 + zero-area exclusion + floor-home pointer; emoji tell curated in to match provenance. NITs: checks.py non-dict-marketplace guards, contract pass now step 1 of the review flow, sync-clause on the traveled OR quote, accent-budget/grid rewording, envelope-synthesis provenance note, README probe-coverage precision. Rejected: #4f46e5 attribution nit (Tailwind palette fact in verified od P0 list). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
grok(6) + gpt-5.6-sol(12), overlaps merged. Highlights: spring table made honest (critical-damping formula added; presets labeled underdamped and scoped to momentum interactions - the table contradicted its own settle rule); exit-ratio vs duration-table incompatibility resolved (rows bound entrances); dismissal rule regains the distance branch + units + release-velocity preference; transition:all rationale corrected (no unconditional-reflow claim); Doherty cite fixed at the source of truth (IBM report GE20-0752, Thadhani) and SS7 relabeled as second-hand at the claim site; SS7/SS4 five-state + color-mode eligibility gated with N/A paths; pre-flight gate split by surface class (marketing budgets no longer leak into APP UI); editors/tables chrome-vs-widget split; fix-loop now requires write authorization; Block scoped to project-governing contracts only; design-review-gate SSSS1-3 labeled unprobed in-skill; five-state table + misquote items reclassified as Apache-2.0 ADAPTATIONS with notices (ideas-only claim was not credible); checks.py hardened (type guards, ./-prefix + realpath containment, per-plugin hooks.json, skills-override rejection - all negative-tested); standalone-install claim qualified; 74 dated. Partial adoption recorded: component-override rejection scoped to hooks+skills (commands/agents remain legitimate). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
grok(2): README source-table cells aligned with the Apache-adaptation reclassification (EN+zh); SS0 APP UI list now 'everything except SS2' so SS6 preservation and SS7's gate still bind. gpt(9, 2 overlapping grok's already-fixed items): Material scrim reworded as color role + component default; WCAG 1.4.11 scoped with exemptions + pack-floor label; SS7 accent box gains the brand-override escape + computed-color check; transform/opacity rule split from paint-only transitions; 500ms CRITICAL carries the spectacle-exception hook; verdict model gains 'Changes required'; document-only review branch added; touch audit selector covers textarea/summary/ARIA roles + effective-hit-area caveat; checks.py: plugins-null guard, opus-pack version isinstance guard, root hooks.json in per-plugin sweep, skill-frontmatter hooks scan - all three new guards negative-tested (structured FAILs, no tracebacks), suite green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s fixed Cap-round close per house precedent (PR #44 pattern): grok round-3 verified every r1/r2 closure against the live tree and returned PROCEED; codex returned 6 NEW findings (none a failed closure), all accepted and fixed with negative tests, recorded on the PR trail instead of an unbounded round 4. Fixes: touch floors relabeled as pack floors over vendor guidance + CSS-px/desktop caveat; physics units stated (projection px/s vs dismissal px/ms - 1000x trap named) + zero-displacement guard; linear scoped to finite point-to-point (spinner/marquee exception named); CSS-var recalc scoped to inheriting/unregistered properties; checks.py: tolerant hooks-key regex (quoted/spaced spellings), commands/root-SKILL frontmatter sweep, marketplace name pin + owner + kebab-case, reverse plugin discovery (unreferenced manifest fails), design-pack README version callout binding, root plugin.json version type guard (grok's non-blocking note, same class). Probes: quoted-hooks caught, unreferenced-plugin caught, stale README version caught, marketplace rename caught; suite + hook tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
design-pack: second plugin with three design-craft skills
A sibling plugin (
design-pack/, v0.1.0) in the same marketplace:ui-design-craft,motion-craft,design-review-gate- domain-craft doctrine in the pack's house style (numeric budgets, prohibited patterns with signatures, observable gates). opus-pack itself bumps to alpha-0.1.15; its nine skills are untouched.Why this shape
Sources and licensing
Text adapted (MIT, notices added): emilkowalski/skills, Leonxlnx/taste-skill, LottieFiles/motion-design-skill, referodesign/refero_skill (mined directly - shortest license chain; refero LICENSE verified MIT). Ideas only: nexu-io/open-design (Apache-2.0; misquote corrections restated with primary citations), garrytan/gstack (its unmeasured numeric heuristics deliberately NOT imported - false precision), benjitaylor/agentation (PolyForm Shield - ideas only by necessity), archify, creative-tim, VoltAgent corpus (pointed at as non-authoritative research material, never vendored). Embedded marketing directives in sources (Emil course plug, GSAP recommend-steering, PRO-key funnels) stripped per skill-authoring §6. "Every incorporated code lineage terminates in MIT" still holds.
Covenant: probes ran before this PR
Private fixtures (evals/design-round1/, gitignored), fresh haiku, bare-vs-ruled arms, expected outcomes written first, n=1 per cell (smoke):
unprobed, harder variant owedRound 0 (8 runs) VOIDED: planted-violation keys had leaked into the fixtures as comments; caught because ACTUAL(BARE) wildly beat EXPECTED(BARE) - the expected-before-actual mechanism, not the score. Ledger: evals/design-round1/PROBES.md.
CI
checks.py generalized to N marketplace plugins (skill-frontmatter scan and README-mention check now DISCOVER roots from marketplace.json; per-plugin manifest identity + version agreement; hooks-field ban on every plugin manifest; fail-closed). Negative-tested live: planted design-pack version mismatch -> the new check fires with the exact message; reverted; suite green. Hook suites + gate template green locally.
Review trail
kCAMediaTimingFunctionDefault/CSSease(the HIG publishes no numeric curves - the mislabel is now itself listed in the skill); WCAG sentence rewritten to true AA floors (placeholder/over-scrim text 4.5:1 normal-size, secondary body text 4.5:1 both modes); a 40-60% scrim figure that traced ONLY to a declared-unmined repo (survey debris entering under wrong attribution) reworded out and re-anchored on Material's published 32% scrim token; touch-audit snippet MIN=48 + zero-area exclusion + floor-home pointer; emoji tell curated in so provenance matches contents. 1 nit rejected with reason (#4f46e5is Tailwind indigo-600, a palette fact in the verified P0 list). The critic's named point-nearest-failure (two attributions it could not verify) was closed by re-grepping both in the clones: gstack anti-convergence phrasing (design-shotgun:1122) and creative-tim's text-xs whitelist (SKILL.md:161) both confirmed.ae8a5af, 1 partially adopted with reason (component-override rejection scoped to hooks+skills), 1 sub-claim rejected with reason (#4f46e5 attribution). Standout catches: the spring table contradicting its own settle rule (damping ratio 0.625-0.75 = underdamped); the misquote-correction section itself miscarrying the Doherty cite (real source: IBM report GE20-0752, "Thadhani"); the five-state table too close to its Apache source for an "ideas only" claim -> reclassified as an attributed Apache-2.0 adaptation. gpt round-1 wrapper exited -1 at the 10-min cap AFTER completing (verdict fully written, 339k tokens; identity = invocation flags + stream); recorded as a note, not a gap.efdaa8e: README table cells aligned with the Apache reclassification, §0 APP-UI carve-out ("everything except §2"), Material scrim as color-role + component default, WCAG 1.4.11 scoped with a labeled pack floor, accent-box override escape + computed-color check, paint-only vs layout-triggering transition split, spectacle-exception hook in the 500ms CRITICAL, three-valued verdict model (Block / Changes required / Approve), document-only review branch, touch-audit ARIA coverage + effective-hit-area confirmation, and four more checks.py guards (plugins:null, non-string version at the opus-pack site, root hooks.json, skill-frontmatter hooks) - each negative-tested."hooks" :spelling caught; unreferenced plugin manifest caught; stale README version caught; marketplace rename caught. Suite + hook tests green atHEAD.Verdict files, packets, and per-round stderr live in the session scratchpad (
consult/); probe ledger in the private suite (evals/design-round1/PROBES.md).🤖 Generated with Claude Code