fix: repurpose featured flag to ensure resources render above fold #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add typing for react-gtm-module fix: temporarily deploy Google Analytics to staging fix: add temporary logging fix: remove GA4 logging
* fix: change language * test: fix test
chadbrokaw
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the event display logic to prioritize featured events, ensuring they appear at the top of the list rather than being the only events fetched. The key change is moving from server-side filtering to client-side sorting of featured events.
Key Changes:
- Updated API query to fetch all events instead of filtering for featured events only
- Added client-side sorting to display featured events first in the list
- Updated the
EventResponseinterface to include thefeaturedboolean property
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/hooks/StrapiAPI.ts | Removed featured filter from API query and added featured boolean to EventResponse interface |
| app/components/ui/Cards/EventCardSection.tsx | Implemented client-side sorting to prioritize featured events using useMemo |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the sorting and display of events in the
EventCardSectioncomponent and updates the event data structure to include afeaturedproperty. The most significant change is that featured events are now prioritized and shown first in the UI.Event sorting and display improvements:
EventCardSectioncomponent now sorts events so that those marked asfeaturedappear before others, usinguseMemofor efficiency. The displayed events and the "show more" logic are updated to use this sorted list. [1] [2]Data model and API changes:
EventResponseinterface is updated to include afeaturedboolean property, ensuring the frontend can recognize and use the featured status of events.useHomePageFeaturedResourcesDatais updated to fetch all events (not just featured ones), allowing the frontend to handle featured sorting client-side.