fix: Remove extra exclusion filters #357
Conversation
Add typing for react-gtm-module fix: temporarily deploy Google Analytics to staging fix: add temporary logging fix: remove GA4 logging
* fix: change language * test: fix test
There was a problem hiding this comment.
Pull Request Overview
This PR removes exclusion filters from search and browse functionality by eliminating the createExclusionFilters utility usage. The changes simplify the filtering logic to use only category-based filtering in browse results, while search results now have no additional filters applied.
Key Changes:
- Removed
createExclusionFiltersimport and usage from both search and browse pages - Simplified
BrowseResultsPageto use only category filters instead of combined category and exclusion filters - Removed filter parameters from
Configurecomponent inSearchResultsPage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/pages/SearchResultsPage/SearchResultsPage.tsx | Removed exclusion filters from search configuration, eliminating all filter parameters |
| app/pages/BrowseResultsPage/BrowseResultsPage.tsx | Simplified filtering to use only category-based filters, removing exclusion filter logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| indexUiState: { query = null }, | ||
| } = useInstantSearch(); | ||
|
|
||
| // Apply Our415 category filtering rules |
There was a problem hiding this comment.
The comment 'Apply Our415 category filtering rules' is now misleading since all filtering logic has been removed. This comment should either be removed or updated to reflect that no filtering is currently applied.
| // Apply Our415 category filtering rules |
| ? escapeApostrophes(parentCategory.name) | ||
| : null; | ||
|
|
||
| // Apply Our415 category filtering rules |
There was a problem hiding this comment.
The comment 'Apply Our415 category filtering rules' no longer accurately describes the code below it, as the exclusion filters and combined filter variables have been removed. Consider updating this comment to clarify that only category filtering is applied.
| // Apply Our415 category filtering rules | |
| // Apply Our415 category filtering |
This pull request removes the use of the
createExclusionFiltersutility and the associated exclusion filters from both theBrowseResultsPageandSearchResultsPagecomponents. Instead, only category-based filtering is applied inBrowseResultsPage, and no exclusion filters are used inSearchResultsPage.Removal of exclusion filters
createExclusionFiltersfrom bothBrowseResultsPage.tsxandSearchResultsPage.tsx, eliminating the application of exclusion filters in search queries. [1] [2] [3] [4] [5]Filtering logic update
Configurecomponent inBrowseResultsPage.tsxto use only category-based filters (categories:'${algoliaCategoryName}') instead of combining with exclusion filters.