Freenor & Bodhi's pearl cost system, rebased on to Exultant's version#16
Open
pruby wants to merge 2 commits intoExultant:masterfrom
Open
Freenor & Bodhi's pearl cost system, rebased on to Exultant's version#16pruby wants to merge 2 commits intoExultant:masterfrom
pruby wants to merge 2 commits intoExultant:masterfrom
Conversation
Author
|
Note: when compiling I still have one error against the CombatTag API, might have the wrong JAR: CombatTagManager Line #39: |
Author
|
Command used to merge on to Exultant/master was: git merge --squash -s recursive -X ignore-all-space -X theirs bodhi/patch-2 Still some whitespace issues it didn't ignore, but can't see substantial changes other than their new code. |
|
Here's the build of Combat-Tag for 1.4.7. https://docs.google.com/file/d/0B1IAk9vOK8e-T1FabUVXbFhoMzA/edit?usp=sharing |
|
It builds fine for me with that Combat-Tag. https://docs.google.com/file/d/0B1IAk9vOK8e-T1V5TTlNTl9RT0U/edit?usp=sharing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prisonpearl cost system has obviously been based on Exultant's version, but the git history shows it being off matthewbot's . This corrects the version history to produce what appears to just be their changes in the changeset.