Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mattdesl!
Some changes:
var draw = Draw(what, how)
. It is compatible with old API, but now user can simply pass a fragment shader source:var draw = create(glslify('shader.frag'))
.draw
, now it is 2-3 times faster in some cases.I know, it is quite big change, and you may not like changed code style/test runner, just wanted to know your opinion and maybe ideas for a new package name then. Maybe
gl-shader-process
orgl-shader-draw
?Thanks anyways.