[iOS & Android] Enable borderRadius in all mention types #720
Conversation
war-in
changed the title
…s to all mentions
war-in
changed the title
apple/MarkdownTextLayoutFragment.mm
Outdated
| CGFloat marginLeft = _markdownUtils.markdownStyle.blockquoteMarginLeft; | ||
| CGFloat borderWidth = _markdownUtils.markdownStyle.blockquoteBorderWidth; | ||
| CGFloat paddingLeft = _markdownUtils.markdownStyle.blockquotePaddingLeft; | ||
| CGFloat shift = marginLeft + borderWidth + paddingLeft; | ||
|
|
||
| fragmentTextBounds.origin.x -= (paddingLeft + borderWidth) + shift * ([_depth unsignedIntValue] - 1); | ||
| fragmentTextBounds.size.width = borderWidth + shift * ([_depth unsignedIntValue] - 1); |
There was a problem hiding this comment.
Looks like the blockquote logic is now duplicated, can we somehow dedupe it?
There was a problem hiding this comment.
It was already :/
I could create a helper function to get the shift to make it look better but the logic would stay unchanged
I think we need it to be that way because boundingRect is also used in renderingSurfaceBounds
war-in
changed the title
…e` to a separate file
android/src/main/java/com/expensify/livemarkdown/spans/MarkdownBackgroundSpan.java
Outdated
Show resolved
Hide resolved
|
I fixed last known iOS issue in this commit - 28b6a13 Before After |
There was a problem hiding this comment.
Dunno if those are connected to this PR, or just existing bugs. In all cases, it's just on mobile devices
- android, switching to single line breaks highlights :(
Screen.Recording.2025-08-22.at.13.04.20.mov
- android, Cursor not visible when within
codeblockormention
Screen.Recording.2025-08-22.at.13.08.38.mov
| mentionHere: { | ||
| color: 'green', | ||
| backgroundColor: 'lime', | ||
| borderRadius: 5, |
There was a problem hiding this comment.
Is it me or default borderRadius for android and web look different ?
There was a problem hiding this comment.
Yeah, saw that too. Not sure why the same radius is smaller on Android 🤔
@tomekzaw any ideas?
|
Very much a nitpick, but when having a multiline mention starting bottom border radius and finish top, should not apply. Same issue for web 
|
|
Na ios dzieją się rzeczy niestworzone :( Ale to też single - line to jest Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-08-22.at.14.34.03.mp4 |
We can try to fix it in a separate PR but I think we need to consult with the design team. I'll leave it as an open idea because it's not in the scope of this PR Thanks for noticing! |
For the context, this was discussed on Slack: https://swmansion.slack.com/archives/C01GTK53T8Q/p1755699466781499 |
3 participants
Details
This PR adds support for
borderRadiusprop in mentions styles on iOS & AndroidRelated Issues
Expensify/App#19299
Manual Tests
iOS & Android:
Linked PRs