Component | Sankey: Zoom & Pan #38
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code for the Zoom / Pan feature has been LLM-generated and was over-engineered in my opinion. This commit makes he code simple and more compact: - Rename and pack some of the variables - Scale vertically from the topmost node - Allow specifying yTolerance for `labelMaxWidthTakeAvailableSpace` - Cache bleed calculations because they are expensive
rokotyan
force-pushed
the
feature/sankey-zoom
branch
from
baf11e3 to
c8e9505
Compare
rokotyan
force-pushed
the
feature/sankey-zoom
branch
from
c8e9505 to
917ef8b
Compare
rokotyan
force-pushed
the
feature/sankey-zoom
branch
from
9bae12c to
9354ce3
Compare
rokotyan
force-pushed
the
feature/sankey-zoom
branch
from
9354ce3 to
fef1c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.