feat: remove protection flag before disabling computers #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to automatically remove the ProtectedFromAccidentalDeletion flag from computer objects before performing disable operations, preventing manual intervention when this flag would otherwise block automated cleanup processes.
- Introduces a new
RemoveProtectedFromAccidentalDeletionFlagswitch parameter toDisable-WinADComputer - Implements protection flag removal logic with proper error handling and event logging
- Adds Pester test coverage for the new flag removal functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/Disable-WinADComputer.Tests.ps1 | New test file validating that the protection flag is removed when requested |
| Public/Invoke-ADComputersCleanup.ps1 | Updated parameter documentation to clarify flag removal applies to disable, move, and delete operations |
| Private/Request-ADComputersDisable.ps1 | Passes the RemoveProtectedFromAccidentalDeletionFlag parameter to both disable and move operations |
| Private/Disable-WinADComputer.ps1 | Implements flag removal logic before disabling computers, with try-catch error handling and event logging |
| Examples/DeleteComputersWithMoveAndEmail.ps1 | Demonstrates usage of the new flag removal parameter in a real-world scenario |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ($Computer.Enabled -eq $true) { | ||
| if ($RemoveProtectedFromAccidentalDeletionFlag -and $Computer.ProtectedFromAccidentalDeletion) { | ||
| try { | ||
| Write-Color -Text "[i] Removing protected from accidental deletion flag for computer ", $Computer.DistinguishedName, ' DN: ', $Computer.DistinguishedName, ' Enabled: ', $Computer.Enabled, ' Operating System: ', $Computer.OperatingSystem, ' LastLogon: ', $Computer.LastLogonDate, " / " , $Computer.LastLogonDays , ' days, PasswordLastSet: ', $Computer.PasswordLastSet, " / ", $Computer.PasswordLastChangedDays, " days" -Color Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green |
There was a problem hiding this comment.
The message contains redundant information. The text includes both "computer " and "DN: " with the same value (DistinguishedName) displayed twice. Consider removing one of these redundant parts to make the message clearer. For example:
Write-Color -Text "[i] Removing protected from accidental deletion flag for computer ", $Computer.SamAccountName, ' DN: ', $Computer.DistinguishedName, ' Enabled: ', $Computer.Enabled, ' Operating System: ', $Computer.OperatingSystem, ' LastLogon: ', $Computer.LastLogonDate, " / " , $Computer.LastLogonDays , ' days, PasswordLastSet: ', $Computer.PasswordLastSet, " / ", $Computer.PasswordLastChangedDays, " days" -Color Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green
Suggested change
| Write-Color -Text "[i] Removing protected from accidental deletion flag for computer ", $Computer.DistinguishedName, ' DN: ', $Computer.DistinguishedName, ' Enabled: ', $Computer.Enabled, ' Operating System: ', $Computer.OperatingSystem, ' LastLogon: ', $Computer.LastLogonDate, " / " , $Computer.LastLogonDays , ' days, PasswordLastSet: ', $Computer.PasswordLastSet, " / ", $Computer.PasswordLastChangedDays, " days" -Color Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green | |
| Write-Color -Text "[i] Removing protected from accidental deletion flag for computer ", $Computer.SamAccountName, ' DN: ', $Computer.DistinguishedName, ' Enabled: ', $Computer.Enabled, ' Operating System: ', $Computer.OperatingSystem, ' LastLogon: ', $Computer.LastLogonDate, " / " , $Computer.LastLogonDays , ' days, PasswordLastSet: ', $Computer.PasswordLastSet, " / ", $Computer.PasswordLastChangedDays, " days" -Color Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green, Yellow, Green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pwsh -NoLogo -NoProfile -Command "Invoke-Pester -Path ./Tests"pwsh -NoLogo -NoProfile -File Build/Build-Module.ps1(fails: The term 'Invoke-ModuleBuild' is not recognized)https://chatgpt.com/codex/tasks/task_e_689510850fdc832ea16b76d72934acb7