Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write a regression test suite that can be sbatch submitted #616

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joanise
Copy link
Member

@joanise joanise commented Dec 20, 2024

Starting to address #611

PR Goal?

Start to write a regression test suite that we can sbatch submit to the cluster with GPUs and whatever memory we need.

For now, I'm using a tiny dataset, but it's easy to adjust to something larger.

Feedback sought?

While this is early, you can already try to give it a spin: edit the two user config variables at the top if needed, and run

sbatch EveryVoice/everyvoice/tests/regression-test.sh

Priority?

beta I guess

Tests added?

nothing but

Confidence?

medium, this still needs more work

Version change?

no

Related PRs?

no

TODO

  • use coverage analysis
  • add at least minimal checks to make sure the output files are as expected
  • run the demo and use playwright to click in it
  • add other variants -- there are lots of paths we can take through the EV pipeline!

Copy link

Review changes with  SemanticDiff

@joanise joanise marked this pull request as draft December 20, 2024 20:56
Copy link
Contributor

CLI load time: 0:00.34
Pull Request HEAD: 8d7f6ab219f2088d9c9e09c2ac578061eb3ba401
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1065 |     104533 |     typer.main
import time:       294 |     124247 |   typer
import time:       265 |     102876 |       everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.cli
import time:       173 |     103487 |     everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli
import time:        18 |     103505 |   everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.preprocess
import time:      7650 |     262131 | everyvoice.cli

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (53c383b) to head (8d7f6ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          46       46           
  Lines        3445     3445           
  Branches      470      470           
=======================================
  Hits         2644     2644           
  Misses        700      700           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant