Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: refactor wizard to avoid expensive imports at CLI startup #615

Merged
merged 1 commit into from
Jan 7, 2025
Merged

perf: refactor wizard to avoid expensive imports at CLI startup #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions everyvoice/tests/stubs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from loguru import logger

from everyvoice import wizard
from everyvoice.wizard import basic, dataset, prompts
from everyvoice.wizard import basic, dataset, prompts, tour


class monkeypatch:
Expand Down Expand Up @@ -315,7 +315,7 @@ def __enter__(self):
patch_name = "questionary"
self.monkeys = [
monkeypatch(module_to_patch, patch_name, stub)
for module_to_patch in [wizard, basic, dataset]
for module_to_patch in [wizard, basic, dataset, tour]
]
return [monkey.__enter__() for monkey in self.monkeys]

Expand Down
4 changes: 2 additions & 2 deletions everyvoice/tests/test_wizard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
patch_menu_prompt,
patch_questionary,
)
from everyvoice.wizard import State, Step
from everyvoice.wizard import StepNames as SN
from everyvoice.wizard import Tour, basic, dataset, prompts, utils
from everyvoice.wizard import basic, dataset, prompts, utils
from everyvoice.wizard.main_tour import get_main_wizard_tour
from everyvoice.wizard.tour import State, Step, Tour

CONTACT_INFO_STATE = State()
CONTACT_INFO_STATE[SN.contact_name_step.value] = "Test Name"
Expand Down
2 changes: 1 addition & 1 deletion everyvoice/tests/test_wizard_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

from everyvoice.tests.stubs import capture_stdout, temp_chdir
from everyvoice.tests.test_wizard import CONTACT_INFO_STATE
from everyvoice.wizard import State
from everyvoice.wizard import StepNames as SN
from everyvoice.wizard.basic import ConfigFormatStep
from everyvoice.wizard.tour import State
from everyvoice.wizard.utils import EnumDict, NodeMixinWithNavigation


Expand Down
Loading
Loading