-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dependabot says to update to torch=2.2.0 #521
base: main
Are you sure you want to change the base?
Conversation
Review changes with SemanticDiff. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 74.48% 74.48%
=======================================
Files 45 45
Lines 3029 3029
Branches 491 491
=======================================
Hits 2256 2256
Misses 679 679
Partials 94 94 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but this will be a breaking change won't it? I guess we should bump the version too
Version bump, sure. |
Right yea - have you tried installing it on gpsc-c with this configuration? I expect it should be fine there, but maybe run into problems elsewhere. Are the dependabot warnings serious? |
fcc3839
to
3ef6be0
Compare
3ef6be0
to
60eb1f3
Compare
We have issues with this PR AS-IS. See attached log file. I am unable to train a model. |
Updating to torch 2.2.0 manually works when I use the latest version of EV. I am having issues with this PR when I try to train a FP. Using this as-is will cause it to crash. ( see below or full job error log attached)
|
PR Goal?
Fix warnings for dependabot:
Fixes?
Feedback sought?
Merge approval
Priority?
medium-high
Tests added?
None
How to test?
Create a new conda environment using
./make-everyvoice-env --name EveryVoice.test
then run./run_tests.py
.The CI also should be testing this.
Confidence?
Good
Version change?
No
Related PRs?
None