Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependabot says to update to torch=2.2.0 #521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamuelLarkin
Copy link
Collaborator

@SamuelLarkin SamuelLarkin commented Jul 25, 2024

Copy link

Review changes with SemanticDiff.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

CLI load time: 0:00.23
Pull Request HEAD: 60eb1f3b75de2a0a2593cb25c6b66581567399dd
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.48%. Comparing base (3830a83) to head (60eb1f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   74.48%   74.48%           
=======================================
  Files          45       45           
  Lines        3029     3029           
  Branches      491      491           
=======================================
  Hits         2256     2256           
  Misses        679      679           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelLarkin SamuelLarkin changed the title [WIP] fix: dependabot says to update to torch=2.2.0 fix: dependabot says to update to torch=2.2.0 Jul 25, 2024
@SamuelLarkin SamuelLarkin requested a review from roedoejet July 25, 2024 16:06
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this will be a breaking change won't it? I guess we should bump the version too

@SamuelLarkin
Copy link
Collaborator Author

Version bump, sure.
I mostly afraid of not been able to run EV on some cluster if we are too bleeding edge (older cluster setup).
May be we should each pull that PR and to more than just the unittests.

@roedoejet
Copy link
Member

Version bump, sure. I mostly afraid of not been able to run EV on some cluster if we are too bleeding edge (older cluster setup). May be we should each pull that PR and to more than just the unittests.

Right yea - have you tried installing it on gpsc-c with this configuration? I expect it should be fine there, but maybe run into problems elsewhere. Are the dependabot warnings serious?

@marctessier
Copy link
Collaborator

We have issues with this PR AS-IS.

See attached log file. I am unable to train a model.

PT2.2.e3333831.txt

@marctessier
Copy link
Collaborator

Updating to torch 2.2.0 manually works when I use the latest version of EV.

I am having issues with this PR when I try to train a FP. Using this as-is will cause it to crash. ( see below or full job error log attached)

RuntimeError: The expanded size of the tensor (103) must match the existing size
(104) at non-singleton dimension 1.  Target sizes: [539, 103].  Tensor sizes: 
[539, 104]
Loading EveryVoice modules: 100%|██████████| 4/4 [00:03<00:00,  1.13it/s]   
srun: error: ib14gpu-004: task 0: Exited with exit code 1

dependabot.e3365197.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants