fix: Close file-handle after checking checksum

EverestAPI · Sep 29, 2024 · 394d5a2 · 394d5a2
1 parent 9fabd4c
commit 394d5a2
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/CelesteTAS-EverestInterop/Source/EverestInterop/StudioHelper.cs b/CelesteTAS-EverestInterop/Source/EverestInterop/StudioHelper.cs
@@ -185,12 +185,14 @@ private static async Task DownloadStudio() {
         bool skipDownload = false;
 
         if (File.Exists(DownloadPath)) {
-            await using var fs = File.OpenRead(DownloadPath);
+            await using (var fs = File.OpenRead(DownloadPath)) {
+                string hash = BitConverter.ToString(await md5.ComputeHashAsync(fs)).Replace("-", "");
+                if (Checksum.Equals(hash, StringComparison.OrdinalIgnoreCase)) {
+                    skipDownload = true;
+                }
+            }
 
-            string hash = BitConverter.ToString(await md5.ComputeHashAsync(fs)).Replace("-", "");
-            if (Checksum.Equals(hash, StringComparison.OrdinalIgnoreCase)) {
-                skipDownload = true;
-            } else {
+            if (!skipDownload) {
                 // Try handling double ZIPs caused by GitHub actions
                 if (DoubleZipArchive) {
                     string innerPath;
@@ -205,7 +207,8 @@ private static async Task DownloadStudio() {
                     File.Move(innerPath, DownloadPath, overwrite: true);
                 }
 
-                hash = BitConverter.ToString(await md5.ComputeHashAsync(fs)).Replace("-", "");
+                await using var fs = File.OpenRead(DownloadPath);
+                string hash = BitConverter.ToString(await md5.ComputeHashAsync(fs)).Replace("-", "");
                 if (Checksum.Equals(hash, StringComparison.OrdinalIgnoreCase)) {
                     skipDownload = true;
                 }