Skip to content

Refactor internals of CelesteTAS #83

Refactor internals of CelesteTAS

Refactor internals of CelesteTAS #83

Triggered via pull request October 28, 2024 23:23
@psyGamerpsyGamer
synchronize #91
refactor
Status Success
Total duration 3m 6s
Artifacts 5

Build.yml

on: pull_request
build-studio  /  build-windows
2m 22s
build-studio / build-windows
build-studio  /  build-linux
36s
build-studio / build-linux
build-studio  /  build-mac
1m 26s
build-studio / build-mac
build-celestetas
26s
build-celestetas
Fit to window
Zoom out
Zoom in

Annotations

40 warnings
build-studio / build-linux
For projects targeting .NET 8.0 and higher, specifying a RuntimeIdentifier will no longer produce a self contained app by default. To continue building self-contained apps, set the SelfContained property to true or use the --self-contained argument.
build-studio / build-linux: external/Featherline/General/RandomClasses.cs#L47
'Vector2' defines operator == or operator != but does not override Object.Equals(object o)
build-studio / build-linux: external/Featherline/General/RandomClasses.cs#L47
'Vector2' defines operator == or operator != but does not override Object.GetHashCode()
build-studio / build-linux: external/Featherline/Simulation/FeatherSim.cs#L84
Cannot convert null literal to non-nullable reference type.
build-studio / build-linux: external/Featherline/General/TimingChange.cs#L11
Cannot convert null literal to non-nullable reference type.
build-studio / build-linux: external/Featherline/Algorithm/GeneticAlg.cs#L28
Dereference of a possibly null reference.
build-studio / build-linux: external/Featherline/Algorithm/GAManager.cs#L45
Possible null reference argument for parameter 'src' in 'AngleSet? GAManager.RawFavorite(string src)'.
build-studio / build-linux: external/Featherline/Algorithm/GAManager.cs#L76
Possible null reference argument for parameter 'src' in 'AngleSet GAManager.ParseFavorite(string src, int targetLen)'.
build-studio / build-linux: external/Featherline/Algorithm/GAManager.cs#L114
Dereference of a possibly null reference.
build-studio / build-mac: external/Featherline/General/RandomClasses.cs#L47
'Vector2' defines operator == or operator != but does not override Object.Equals(object o)
build-studio / build-mac: external/Featherline/General/RandomClasses.cs#L47
'Vector2' defines operator == or operator != but does not override Object.GetHashCode()
build-studio / build-mac: external/Featherline/General/TimingChange.cs#L11
Cannot convert null literal to non-nullable reference type.
build-studio / build-mac: external/Featherline/Simulation/FeatherSim.cs#L84
Cannot convert null literal to non-nullable reference type.
build-studio / build-mac: external/Featherline/Algorithm/GAManager.cs#L45
Possible null reference argument for parameter 'src' in 'AngleSet? GAManager.RawFavorite(string src)'.
build-studio / build-mac: external/Featherline/Algorithm/GAManager.cs#L76
Possible null reference argument for parameter 'src' in 'AngleSet GAManager.ParseFavorite(string src, int targetLen)'.
build-studio / build-mac: external/Featherline/Algorithm/GeneticAlg.cs#L28
Dereference of a possibly null reference.
build-studio / build-mac: external/Featherline/Algorithm/GAManager.cs#L114
Dereference of a possibly null reference.
build-studio / build-mac: external/Featherline/Algorithm/GeneticAlg.cs#L81
Cannot convert null literal to non-nullable reference type.
build-studio / build-windows: external/Featherline/General/RandomClasses.cs#L47
'Vector2' defines operator == or operator != but does not override Object.Equals(object o)
build-studio / build-windows: external/Featherline/General/RandomClasses.cs#L47
'Vector2' defines operator == or operator != but does not override Object.GetHashCode()
build-studio / build-windows: external/Featherline/General/TimingChange.cs#L11
Cannot convert null literal to non-nullable reference type.
build-studio / build-windows: external/Featherline/Simulation/FeatherSim.cs#L84
Cannot convert null literal to non-nullable reference type.
build-studio / build-windows: external/Featherline/Algorithm/GeneticAlg.cs#L198
Cannot convert null literal to non-nullable reference type.
build-studio / build-windows: external/Featherline/Algorithm/GeneticAlg.cs#L205
Cannot convert null literal to non-nullable reference type.
build-studio / build-windows: external/Featherline/Algorithm/GeneticAlg.cs#L206
Cannot convert null literal to non-nullable reference type.
build-studio / build-windows: external/Featherline/Algorithm/GeneticAlg.cs#L28
Dereference of a possibly null reference.
build-studio / build-windows: external/Featherline/Algorithm/GAManager.cs#L45
Possible null reference argument for parameter 'src' in 'AngleSet? GAManager.RawFavorite(string src)'.
build-celestetas: CelesteTAS-EverestInterop/Source/Module/CelesteTasMenu.cs#L270
'EaseInSubMenu.ease' hides inherited member 'TextMenuExt.SubMenu.ease'. Use the new keyword if hiding was intended.
build-celestetas: CelesteTAS-EverestInterop/Source/Utils/HookHelper.cs#L114
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build-celestetas: CelesteTAS-EverestInterop/Source/TAS/Input/Commands/ReadCommand.cs#L179
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build-celestetas: CelesteTAS-EverestInterop/Source/TAS/Input/Commands/AssertCommand.cs#L63
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build-celestetas: CelesteTAS-EverestInterop/Source/EverestInterop/ConsoleEnhancements.cs#L54
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
build-celestetas: CelesteTAS-EverestInterop/Source/EverestInterop/FastForwardBoost.cs#L37
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
build-celestetas: CelesteTAS-EverestInterop/Source/EverestInterop/Lua/EvalLuaCommand.cs#L54
Avoid passing lambdas to ILCursor.EmitDelegate, as it emits inefficient code. Pass a reference (method group) to a static method instead.
build-celestetas: CelesteTAS-EverestInterop/Source/EverestInterop/Hitboxes/HitboxToggle.cs#L34
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions
build-celestetas: CelesteTAS-EverestInterop/Source/EverestInterop/Hitboxes/HitboxSimplified.cs#L269
Avoid passing several predicates to ILCursor.(Try)Goto* methods, as other hooks might inject instructions between the target instructions. If possible, split them into separate calls instead.
build-celestetas: CelesteTAS-EverestInterop/Source/EverestInterop/Hitboxes/HitboxSimplified.cs#L282
Don't call ILCursor.Remove or RemoveRange, as it can break other IL hooks which search for the removed instructions

Artifacts

Produced during runtime
Name Size
CelesteStudio-linux-x64 Expired
38 MB
CelesteStudio-macos-arm64 Expired
36.6 MB
CelesteStudio-macos-x64 Expired
38 MB
CelesteStudio-windows-x64 Expired
72.1 MB
CelesteTAS Expired
809 KB